Renamed ClaimImpl.kt to JsonClaim.kt. Cached base64Decoder. Generated IMPROVEMENTS.md. - #2
Open
tberchanov wants to merge 3 commits into
Open
Renamed ClaimImpl.kt to JsonClaim.kt. Cached base64Decoder. Generated IMPROVEMENTS.md.#2tberchanov wants to merge 3 commits into
tberchanov wants to merge 3 commits into
Conversation
azazellj
requested changes
Aug 19, 2025
|
|
||
| ## 🚨 Critical Security Issues | ||
|
|
||
| ### 1. No Signature Verification |
Member
There was a problem hiding this comment.
Initially this repo has an exact purpose - decode tokens, just to be able to fetch parts from string and use it. As initial codebase was not great from the implementation point of view, we can proceed with better implementation. I'm going to create an issue for this: #3
| fun verify(jwt: JWT): VerificationResult | ||
| } | ||
|
|
||
| sealed class VerificationResult { |
| ``` | ||
|
|
||
| ### 2. No Algorithm Validation | ||
| **Current State**: No validation of the algorithm specified in the JWT header. |
Member
There was a problem hiding this comment.
Should this be a part of constructor and throw an exception?
| ### 3. No Input Validation | ||
| **Current State**: Accepts any string input without validation. | ||
|
|
||
| **Code Example**: |
Member
There was a problem hiding this comment.
Sounds valid.
Question - use required in constructor or throw other exceptions?
|
|
||
| companion object { | ||
| private const val MAX_TOKEN_LENGTH = 8192 | ||
| private val TOKEN_PATTERN = Regex("^[A-Za-z0-9+/=_-]+\\.([A-Za-z0-9+/=_-]+)\\.([A-Za-z0-9+/=_-]*)$") |
Member
There was a problem hiding this comment.
Explanation for non-regex friendly devs might be useful
| ### 16. Missing Sample Applications | ||
| **Current State**: No example applications demonstrating how to use the JWTDecode library. | ||
|
|
||
| **Missing Examples**: |
Member
There was a problem hiding this comment.
android & iOS app are present, for other platforms we are gonna go when basic APIs gonna be stable.
|
|
||
| ### 17. Add Key Management | ||
| **Implementation**: | ||
| ```kotlin |
| ### 18. Add Streaming Support | ||
| **Implementation**: | ||
| ```kotlin | ||
| // For large JWTs |
| ### 19. Add Batch Processing | ||
| **Implementation**: | ||
| ```kotlin | ||
| interface JWTBatchProcessor { |
| ## 🔄 Future-Proofing Areas | ||
|
|
||
| ### 20. Add Plugin System | ||
| **Implementation**: |
azazellj
force-pushed
the
main
branch
2 times, most recently
from
August 27, 2025 16:20
b0c4b3b to
87b4f76
Compare
… IMPROVEMENTS.md.
azazellj
force-pushed
the
main
branch
2 times, most recently
from
September 30, 2025 21:02
d6f99b9 to
49034c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.