fix: REPL JOIN hardening — qualifier round-trip, loud no-extension failure, bare-alias sort rejection (#157, #158, #159)

[fupelaqu]

Fixes #157, fixes #158, fixes #159 — the three REPL/JOIN bugs found during the R1 installer E2E verification and the #158 code review, targeted at the 0.20.1 patch line.

#158 — preserve table-alias qualifier in FieldSort SQL rendering

FieldSort.sql was the only clause renderer going through Identifier.identifierName (qualifier-dropping); the REPL JOIN path re-renders the parsed statement via .sql and re-parses it in the arrow JoinPlanner, which rejected the manufactured unqualified column as ambiguous. Now renders via field.sql. FieldSort.name / identifierName / aliasOrName are byte-for-byte untouched (they key the ES-side sort maps).

• 6 ParserSpec round-trip tests (JOIN qualifier, mixed qualification, UNNEST alias, DISTINCT aggregate, qualifier+NULLS composition, unaliased ranking-window derived name) — each re-parses the rendered SQL
• Cross-repo integration: arrow JoinExtensionIntegrationSpec template gains a JOIN + ORDER BY <alias>.<field> DESC ordered-rows test; Es6/Es7/Es8/Es9 runners 13/13 green against live ES (arrow-side change ships separately)
• Accepted (reviewed) behavior change: unaliased window columns over a qualified sort derive a qualified name (row_number_over_order_by_e_salary_desc), consistent with PARTITION BY

#157 — fail loudly on cross-index JOIN without a join-capable extension

CoreDqlExtension (inherited by EnforcedDqlExtension) translates only the first FROM table: without softclient4es-arrow-extensions on the classpath a SELECT … JOIN silently executed as a single-index search (joined columns NULL, orphans kept) — and INSERT … SELECT / CREATE TABLE … AS SELECT wrote that wrong data. Any statement whose (embedded) SELECT has from.enrichmentRequired now fails with a clear 400 pointing at the extensions jar; canHandle additionally claims write-with-JOIN statements (mirroring the arrow JoinExtension) so they cannot fall through to the core DML/DDL executors. UNNEST joins are excluded by construction. With the arrow JoinExtension registered at priority 40 (arrow#125), join statements never reach the guard.

• 6 new CoreDqlExtensionSpec tests: SELECT JOIN, UNION leg, UNNEST carve-out, INSERT…SELECT, CTAS, canHandle claims

#159 — reject ORDER BY on a bare table alias

ORDER BY e where e aliases a FROM table (or ORDER BY oi on an UNNEST alias) left the alias-split with an empty column name, silently rendering malformed SQL (ORDER BY e. after #158; ORDER BY ASC before it). FieldSort.validate now rejects it with Column name expected after table alias '<alias>', surfaced at Parser.apply.

• 2 new ParserSpec rejection tests (table alias, UNNEST alias)

Verification

• + sql/test 376/376, + softclient4es-sql-bridge/test 118/118, + core/test 605/605 — Scala 2.12.20 and 2.13.16
• + compile, scalafmtAll, headerCheck green
• ES8 integration (pre-review, REPL JOIN + ORDER BY fails: qualifier lost in AST→SQL reconstruction ('Ambiguous column') #158): JavaClient8ReplGatewayIntegrationSpec 55/55, JavaClientGatewayApiSpec 43/43, JavaClientSortNullsSpec 3/3
• Adversarial code review (Blind Hunter / Edge Case Hunter / Acceptance Auditor) run on REPL JOIN + ORDER BY fails: qualifier lost in AST→SQL reconstruction ('Ambiguous column') #158; all findings resolved — SQL parser: ORDER BY on a bare table alias produces an empty column name (dangling qualifier) #159 is the promoted deferred finding

🤖 Generated with Claude Code