detect new models in the UI when the project path is a symlink#5861
Open
p-j-smith wants to merge 4 commits into
Open
detect new models in the UI when the project path is a symlink#5861p-j-smith wants to merge 4 commits into
p-j-smith wants to merge 4 commits into
Conversation
Test that the watcher picks up files created in a Context where the project is a symlinked path Signed-off-by: Paul Smith <paul.j.smith@ucl.ac.uk>
can report resolved paths even when the watched root is a symlink, so the watcher's and model-dir checks failed and new files were never tracked, meaning newly created models never showed up in the UI. Compare paths in resolved space and re-root under the project path Signed-off-by: Paul Smith <paul.j.smith@ucl.ac.uk>
Signed-off-by: Paul Smith <paul.j.smith@ucl.ac.uk>
Signed-off-by: Paul Smith <paul.j.smith@ucl.ac.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5860
awatchcan report resolved paths even for a symlinked root, which broke the watcher's path handling. Now, compare paths in resolved space and re-root under the project path so it works either wayin_paths) check too, so new files under a symlinked project get tracked.watch_projectthat is always truthy (should_reset_mtime = change == Change.added or is_modified_new_file). Fix this so thatshould_reset_mtimeis not alwaysTrueTest Plan
Added a new file
tests/web/test_watcher.pythat:Contextwith the symlinked project. Add a new file and check it is picked up by the watcherChecklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO