Skip to content

Comment suppport mssql fabric fix #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ujfalusis wants to merge 5 commits into
base: main
Choose a base branch
from
+4 −0
Open

Comment suppport mssql fabric fix #5862

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6fe61bc
Comment registration support for MSSQL engine
ujfalusis Jun 23, 2026
0bd196f
Merge branch 'SQLMesh:main' into comment_suppport_mssql
ujfalusis Jun 23, 2026
633910b
Comment registration support for MSSQL engine
ujfalusis Jun 26, 2026
da6f6a2
Merge branch 'comment_suppport_mssql' of https://github.com/integrity…
ujfalusis Jun 26, 2026
64609d0
Merge branch 'SQLMesh:main' into comment_suppport_mssql
ujfalusis Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions sqlmesh/core/engine_adapter/fabric.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
from tenacity import retry, stop_after_attempt, wait_exponential, retry_if_result
from sqlmesh.core.engine_adapter.mssql import MSSQLEngineAdapter
from sqlmesh.core.engine_adapter.shared import (
CommentCreationTable,
CommentCreationView,
InsertOverwriteStrategy,
)
from sqlmesh.utils.errors import SQLMeshError
Expand All @@ -30,6 +32,8 @@ class FabricEngineAdapter(MSSQLEngineAdapter):
SUPPORTS_TRANSACTIONS = False
SUPPORTS_CREATE_DROP_CATALOG = True
INSERT_OVERWRITE_STRATEGY = InsertOverwriteStrategy.DELETE_INSERT
COMMENT_CREATION_TABLE = CommentCreationTable.UNSUPPORTED
COMMENT_CREATION_VIEW = CommentCreationView.UNSUPPORTED

def __init__(
self, connection_factory_or_pool: t.Union[t.Callable, t.Any], *args: t.Any, **kwargs: t.Any
Expand Down
Loading