@W-23128917 document order hook lifecycle and two-hook pattern#577
Open
charithaT07 wants to merge 1 commit into
Open
@W-23128917 document order hook lifecycle and two-hook pattern#577charithaT07 wants to merge 1 commit into
charithaT07 wants to merge 1 commit into
Conversation
@W-23157033 Add order hook rollback semantics, the afterPOST + modifyPOSTResponse two-hook pattern for persisting failed orders while returning HTTP errors, and request.custom inter-hook data passing to the b2c-hooks skill. Includes new ORDER-HOOK-LIFECYCLE.md reference and additional trigger eval queries.
charithaT07
marked this pull request as ready for review
July 16, 2026 12:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@W-23157033 Add order hook rollback semantics, the afterPOST + modifyPOSTResponse two-hook pattern for persisting failed orders while returning HTTP errors, and request.custom inter-hook data passing to the b2c-hooks skill. Includes new ORDER-HOOK-LIFECYCLE.md reference and additional trigger eval queries.
Summary
beforePOST→afterPOST(inside txn) →modifyPOSTResponse(after commit)Status.ERRORinafterPOSTrolls back the order; inmodifyPOSTResponseit does notrequest.customas the idiomatic channel for inter-hook data passingORDER-HOOK-LIFECYCLE.mdreference with full code examples and verified sandbox resultsContext
Follow-up to W-23128917. While building the production-triage demo on zzpq-019, we discovered that a single
afterPOSThook cannot both persist a failed order and return an error — the b2c-hooks skill did not document this constraint or theworkaround.
Test plan
pnpm run skills:eval -- --skill-path skills/b2c/skills/b2c-hooksto verify trigger accuracyDependencies
3pl-approvedis set by a maintainerpnpm test)pnpm run format)