⚡ Bolt: Single-pass expression normalization - #8
Conversation
Consolidates `normalize_expression` logic into a single pass string processor. Removes redundant `.replace` calls and intermediate string allocations. Co-authored-by: SayanthRock <202829406+SayanthRock@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
You've hit your review limit for the week, but don't worry you'll get some more next week! Contact us at hello@zenable.io if you want this rate limit to go away |
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
codeant-ai
Bot
added
the
size:M
📝 WalkthroughWalkthroughThe expression normalizer now combines numeric-separator removal, operator normalization, keyword uppercasing, and quoted-string preservation in one character scan. ChangesExpression Normalization
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@compiler/rockql-sql/src/lib.rs`:
- Around line 199-212: The numeric-separator handling around the word-token
construction currently removes underscores from identifiers such as metric_1_2.
Restrict the skip logic in the tokenizer to underscores within numeric literal
tokens only, preserving underscores in identifier tokens; add a regression test
covering metric_1_2 and its generated SQL reference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 1d281157-e11a-4464-8c11-655ba9334252
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
compiler/rockql-sql/src/lib.rs
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
User description
💡 What: Refactored
normalize_expressionto use a single pass character stream approach, integrating operator replacement (==and!=), keyword replacement, and numeric separator removal directly into the state machine.🎯 Why: Previously,
normalize_expressioninvokedremove_numeric_separators, followed by two.replacecalls, and finallynormalize_keywords. Each step iterated over the string completely and allocated new intermediateStringinstances. This caused huge heap traffic and was generally slow in tight loops. Additionally, the naive.replacecalls could improperly touch literal strings containing those operators (e.g.,'foo != bar').📊 Impact: Reduces allocations for expression normalization from 4+ strings to just 1 pre-sized string. Cuts the number of string iterations down to a single O(N) pass. Also fixes a correctness bug regarding operators inside quoted strings.
🔬 Measurement: Verify by running
cargo testto ensure all parsing and code generation still functions identically to the previous version. The performance improvement can be measured by reduced peak memory usage and fewer instruction counts for thenormalize_expressionpipeline.PR created automatically by Jules for task 16922693729256795883 started by @SayanthRock
CodeAnt-AI Description
Speed up expression normalization while preserving quoted text
What Changed
!=and==, numeric separators, and supported keywords are converted during normalizationImpact
✅ Faster expression processing✅ Lower memory use during parsing✅ Preserved quoted string contents💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
!=and==operators.