Test Codex plugin skill contracts#171
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0a96625b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d0a9662 to
b0375b2
Compare
b0375b2 to
00c2503
Compare
Give the crate one line-ending-tolerant SKILL.md frontmatter parser with typed Scalar/Block values and proper YAML single-quote unescaping, and rewire the Hermes skill inventory onto it instead of its bespoke copy.
Reuse the canonical frontmatter parser so the contract tests survive CRLF checkouts (this PR's Windows CI failure), replace the generated-bundle contract re-runs with byte-parity against the source tree, pin TRACEDECAY_DATA_DIR for hermetic installs, narrow the running-impacted-tests parity exemption to frontmatter only, loosen the trigger-language heuristic to a documented rule, document the size budgets, and rename the test to plugin_skill_contract_test.rs to match its Codex+Cursor scope.
|
Addressed in bc2129f: |
Summary
tests/plugin_skill_contract_test.rs) that mirror Codex skill-creator quick_validate rules for bundled Codex skillssrc/automation/skill_frontmatter.rs) shared by the contract tests and the Hermes skill inventory, replacing bespoke per-site parsingsrc/agents/codex.rsto frontmatter only, so the skill bodies must still mirror byte-for-byteTests