Filters nested asso extended#1
Merged
Seb33300 merged 13 commits intoJul 4, 2026
Merged
Conversation
# Conflicts: # config/services.php # src/Field/Configurator/AssociationConfigurator.php # src/Field/Configurator/CollectionConfigurator.php # src/Orm/EntityRepository.php # tests/Unit/Field/Configurator/AssociationConfiguratorTest.php # tests/Unit/Orm/EntityRepositoryTest.php
Seb33300
force-pushed
the
filters-nested-asso
branch
from
1be57a5 to
6459419
Compare
Owner
|
Hi @KDederichs |
Seb33300
requested changes
Jul 4, 2026
…nd moved it back down
KDederichs
force-pushed
the
filters-nested-asso-extended
branch
from
a5c2487 to
662033f
Compare
Seb33300
requested changes
Jul 4, 2026
Seb33300
reviewed
Jul 4, 2026
Seb33300
reviewed
Jul 4, 2026
Seb33300
reviewed
Jul 4, 2026
Seb33300
reviewed
Jul 4, 2026
Owner
|
No more comment on my side, Thanks! |
Author
|
Nice, I committed the 2 small things you mentioned earlier |
Owner
|
linter and phpstan checks are failing |
Author
|
yup I saw, this should fix it I think, I don't have a local copy of the linter atm so I'm not sure about that one but the PHPStan errors are gone |
Author
|
ok missed some linebreaks, should be good now |
Seb33300
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added tests for your changes.
At the same time I also imported my PRs and merged the newest 5.x branch and resolved the conflicts