[codex] Remove stale CollectiveX workflow / 删除过时的 CollectiveX 工作流#2040
[codex] Remove stale CollectiveX workflow / 删除过时的 CollectiveX 工作流#2040Oseltamivir wants to merge 1 commit into
Conversation
|
Claude finished @Oseltamivir's task in 1m 17s —— View job Review
LGTM - no blocking issues found Verified the deletion is clean:
Removing it also stops exposing runner node names ( |
There was a problem hiding this comment.
Straightforward deletion of an unused workflow file — the referenced experimental/CollectiveX/ directory doesn't exist on main.
Extended reasoning...
Overview
Deletes a single GitHub Actions workflow file (.github/workflows/collectivex-sweep.yml, 154 lines) that was dispatch-only and referenced experimental/CollectiveX/ scripts and launchers. That directory does not exist on main (verified — experimental/ contains only dsv32, kvcache_transfer_DtoH_HtoD, multiturn, single_node_decodeonly, token_position_decode_slo, README.md), so the workflow was unrunnable in its current location. No other references to CollectiveX remain in .github/workflows/.
Security risks
None — this is a pure deletion. It actually reduces information exposure on the default branch by removing hardcoded runner names (mia1-p01-g10, mia1-p01-g15) and internal storage paths (/mnt/lustre01/users-public/sa-shared/cx-stage) that were baked into the workflow env.
Level of scrutiny
Low. This is a mechanical cleanup: a single-file deletion of dead configuration that couldn't run anyway. No logic changes, no dependency changes, no runtime code affected. The PR author notes a sanitized replacement will land on the v1 branch separately.
Other factors
Bug hunting agent found no issues. The change is fully self-contained and trivially reversible via git if the removal turns out to be premature.
Summary
main.main; the reviewed v1 branch will add a sanitized replacement separately.Validation
git diff --check.github/orexperimental/on this branch.中文说明
main删除过时且仅支持手动触发的 CollectiveX 工作流。main中没有对应的 CollectiveX 源码;经过审查的 v1 分支会单独添加已清理的替代工作流。验证
git diff --check.github/和experimental/下不再有 CollectiveX 引用。