Skip to content

[codex] Remove stale CollectiveX workflow / 删除过时的 CollectiveX 工作流#2040

Open
Oseltamivir wants to merge 1 commit into
mainfrom
codex/remove-stale-collectivex-workflow
Open

[codex] Remove stale CollectiveX workflow / 删除过时的 CollectiveX 工作流#2040
Oseltamivir wants to merge 1 commit into
mainfrom
codex/remove-stale-collectivex-workflow

Conversation

@Oseltamivir

Copy link
Copy Markdown
Collaborator

Summary

  • Remove the obsolete dispatch-only CollectiveX workflow from main.
  • Stop exposing runner-specific node and storage metadata in the default branch.
  • The workflow was unusable because the corresponding CollectiveX source is not present on main; the reviewed v1 branch will add a sanitized replacement separately.

Validation

  • git diff --check
  • Confirmed no remaining CollectiveX references under .github/ or experimental/ on this branch.

中文说明

  • main 删除过时且仅支持手动触发的 CollectiveX 工作流。
  • 避免默认分支继续暴露运行节点和存储路径等基础设施信息。
  • 该工作流无法运行,因为 main 中没有对应的 CollectiveX 源码;经过审查的 v1 分支会单独添加已清理的替代工作流。

验证

  • git diff --check
  • 已确认此分支的 .github/experimental/ 下不再有 CollectiveX 引用。

@Oseltamivir Oseltamivir marked this pull request as ready for review July 4, 2026 03:59
@Oseltamivir Oseltamivir requested a review from a team July 4, 2026 03:59
@claude

claude Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished @Oseltamivir's task in 1m 17s —— View job


Review

  • Gather context (diff, deleted workflow contents)
  • Check for dangling CollectiveX references on this branch
  • Verify the referenced source (experimental/CollectiveX/) is absent on main
  • Post review

LGTM - no blocking issues found

Verified the deletion is clean:

  • The removed workflow's setup job ran in working-directory: experimental/CollectiveX, which does not exist on main — the workflow was genuinely dead (any dispatch would fail immediately at that step).
  • No remaining CollectiveX references anywhere in the repo after this change (checked .github/, experimental/, and the full tree).
  • Pure deletion, dispatch-only workflow, nothing else depends on it (no workflow_call/workflow_run consumers).

Removing it also stops exposing runner node names (mia1-p01-g10,mia1-p01-g15) and internal storage paths (/mnt/lustre01/...) from the default branch, as described.

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward deletion of an unused workflow file — the referenced experimental/CollectiveX/ directory doesn't exist on main.

Extended reasoning...

Overview

Deletes a single GitHub Actions workflow file (.github/workflows/collectivex-sweep.yml, 154 lines) that was dispatch-only and referenced experimental/CollectiveX/ scripts and launchers. That directory does not exist on main (verified — experimental/ contains only dsv32, kvcache_transfer_DtoH_HtoD, multiturn, single_node_decodeonly, token_position_decode_slo, README.md), so the workflow was unrunnable in its current location. No other references to CollectiveX remain in .github/workflows/.

Security risks

None — this is a pure deletion. It actually reduces information exposure on the default branch by removing hardcoded runner names (mia1-p01-g10, mia1-p01-g15) and internal storage paths (/mnt/lustre01/users-public/sa-shared/cx-stage) that were baked into the workflow env.

Level of scrutiny

Low. This is a mechanical cleanup: a single-file deletion of dead configuration that couldn't run anyway. No logic changes, no dependency changes, no runtime code affected. The PR author notes a sanitized replacement will land on the v1 branch separately.

Other factors

Bug hunting agent found no issues. The change is fully self-contained and trivially reversible via git if the removal turns out to be premature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant