Skip to content

[Klaud Cold] Update kimik2.5-fp4-mi355x-vllm vLLM ROCm image to v0.24.0 / 将 kimik2.5-fp4-mi355x-vllm 的 vLLM ROCm 镜像 升级至 v0.24.0#2074

Open
functionstackx wants to merge 1 commit into
mainfrom
klaud-cold/kimik2.5-fp4-mi355x-vllm-v0.24.0
Open

[Klaud Cold] Update kimik2.5-fp4-mi355x-vllm vLLM ROCm image to v0.24.0 / 将 kimik2.5-fp4-mi355x-vllm 的 vLLM ROCm 镜像 升级至 v0.24.0#2074
functionstackx wants to merge 1 commit into
mainfrom
klaud-cold/kimik2.5-fp4-mi355x-vllm-v0.24.0

Conversation

@functionstackx

Copy link
Copy Markdown
Collaborator

Summary

Update vLLM ROCm image from vllm/vllm-openai-rocm:v0.22.0 to vllm/vllm-openai-rocm:v0.24.0

Recipes touched: kimik2.5-fp4-mi355x-vllm

中文说明

将 vLLM ROCm 镜像 从 vllm/vllm-openai-rocm:v0.22.0 升级至 vllm/vllm-openai-rocm:v0.24.0。涉及配置:kimik2.5-fp4-mi355x-vllm

Test plan

  • full-sweep-fail-fast sweep passes.

🤖 Generated with Claude Code

中文:将 kimik2.5-fp4-mi355x-vllm 的 vLLM ROCm 镜像 升级至 v0.24.0。

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@functionstackx functionstackx force-pushed the klaud-cold/kimik2.5-fp4-mi355x-vllm-v0.24.0 branch from 45f35c4 to a815e38 Compare July 4, 2026 21:24
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-enabled or full-sweep-fail-fast label to this PR — the benchmark sweep only runs on labeled PRs.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-enabledfull-sweep-fail-fast 标签 — 基准测试 sweep 仅在带有标签的 PR 上运行。

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

1 similar comment
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown
Contributor

Thanks for the contribution! Please reach out to respective companies' CODEOWNER to fill in the latest PR_REVIEW_CHECKLIST.md before pinging core maintainer on Slack for review. In order for the signoff PR check bot to trigger, you must follow the PR_REVIEW_CHECKLIST.md template correctly, including the phrase As a PR reviewer and CODEOWNER, I have reviewed this and have.

For PR verification, add the full-sweep-enabled or full-sweep-fail-fast label to this PR — the benchmark sweep only runs on labeled PRs.

PR authors are responsible for ensuring that after merging, all GitHub Action jobs fully pass. A lot of the time, failures are just flakes and simply re-running the failed jobs will fix it. See GitHub's docs on re-running failed jobs


感谢你的贡献!请联系相应公司的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,然后再在 Slack 上联系核心维护者进行审阅。为了触发 signoff PR 检查机器人,你必须正确遵循 PR_REVIEW_CHECKLIST.md 模板,包括保留英文语句 As a PR reviewer and CODEOWNER, I have reviewed this and have

如需进行 PR 验证,请为此 PR 添加 full-sweep-enabledfull-sweep-fail-fast 标签 — 基准测试 sweep 仅在带有标签的 PR 上运行。

PR 作者有责任确保合并后所有 GitHub Action 任务完全通过。 很多时候失败只是偶发抖动(flake),重新运行失败的任务即可解决。参见 GitHub 关于重新运行失败任务的文档

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — single-recipe vLLM ROCm image bump with matching perf-changelog entry.

Extended reasoning...

Overview

This is a [Klaud Cold] automated image bump for the kimik2.5-fp4-mi355x-vllm recipe in configs/amd-master.yaml, moving the vLLM ROCm image from v0.22.0 to v0.24.0. A matching entry is appended to perf-changelog.yaml. The diff is 2 lines in the master config plus a well-formed 6-line changelog block, and touches no code paths.

Security risks

None. Both changes are YAML data — a container image tag and a changelog stanza. The new image tag points to an official vllm/vllm-openai-rocm release (v0.24.0), same registry and repository as the prior pin, so there's no supply-chain shape change.

Level of scrutiny

Low. This is a recipe-only image bump on a single MI355X recipe, gated by full-sweep-fail-fast in CI. The other kimik2.5 / gptoss recipes that pin v0.22.0 (kimik2.5-fp4-mi355x-vllm-agentic, gptoss-fp4-mi325x-vllm, gptoss-fp4-mi355x-vllm, dsv4-fp4-mi355x-vllm-mtp, dsv4-fp4-mi355x-vllm-agentic) are intentionally left alone, which matches the PR description that scopes the change to kimik2.5-fp4-mi355x-vllm only.

Other factors

No prior reviewer comments to address, no bugs surfaced by the bug hunter, and the changelog entry cross-links back to PR #2074 in the standard format used by neighboring entries. Correctness is validated by the sweep label rather than static review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant