Reorganize SharePoint Embedded docs#10941
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 76dc45c:
|
marcwindle
force-pushed
the
mawin-microsoft/sp-dev-docs-embedded-cleanup
branch
from
76dc45c to
8061f93
Compare
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 8061f93:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
marcwindle
force-pushed
the
mawin-microsoft/sp-dev-docs-embedded-cleanup
branch
from
8061f93 to
de6d558
Compare
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit de6d558: 💡 Validation status: suggestionsThis comment lists only the first 25 files in the pull request. docs/embedded/admin/setup-billing-m365-admin-center.md
docs/embedded/build/configure-authentication-authorization.md
docs/embedded/build/create-container-type.md
docs/embedded/build/open-office-files.md
docs/embedded/plan/container-types-and-containers.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
|
||
| ## Get the DriveItem web URL | ||
| When your app retrieves a DriveItem from Microsoft Graph, the response can include `webUrl`. | ||
| For supported Office file types, `webUrl` can point to a WOPI URL that opens the document in Office for the web. |
There was a problem hiding this comment.
What is WOPI and how is it relevant? No prior context on WOPI here and it just isn't relevant.
Also "can point"? That's not helpful. Will it point to the Office online or not?
| For supported Office file types, `webUrl` can point to a WOPI URL that opens the document in Office for the web. | |
| For supported Office file types, `webUrl` points to a URL that opens the document in Office for the web. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit d7affce: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 2598e33: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
Address 59 findings from the automated SharePoint Embedded docs review (style + accuracy reviewers): correct inaccurate API details (trial container storage 200 MB -> 1 GB, container type registration API GA on Graph v1.0 rather than preview/beta, deleteOwnPermission enum value, delegated FileStorageContainer.Selected consent), add missing required metadata (ms.reviewer, **Applies to:** line, agent blocks), fix ms.localizationpriority, apply M365 style/terminology consistency, and refresh ms.date. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8fd1d0ed-ce54-4cbf-b83a-70b7c71f122e
Automated SharePoint Embedded docs review — resultsRan a multi-agent documentation review over the SharePoint Embedded docs ( Issues found60 findings across 40 files (after removing 5 false positives about container-type creation requiring an admin role — non-administrators can create container types):
By reviewer: style 50, accuracy 10. The code reviewer (documented-vs-implemented cross-check against API controllers) skipped — so implementation mismatches were not verified. Top accuracy issues (all fixed):
Top style/convention issues (fixed):
Fixes suggested / applied
Review generated by the repo's |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 451c745: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
- add ai-usage: ai-assisted to all embedded pages - add ms.author: mawin to new embedded articles - reflow body paragraphs to one sentence per block
|
Learn Build status updates of commit 9f5f335: ❌ Validation status: errorsPlease follow instructions here which may help to resolve issue.
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
andrewconnell
left a comment
andrewconnell
left a comment
There was a problem hiding this comment.
Changes applied across multiple files:
- seems clear that AI was used to generate (or at least assist) in these articles; per msdocs guidance, adding required attribute to frontmatter
- don't update the
ms.date- this should be set to the page creation date and not changed; let the rendering engine generate last modified date via git history for the page - markdown formatting:
- add line breaks between content blocks for maintainability
must fix
merge conflict with underlying page that was updated in previously merged PR
| title: Consuming Tenant Admin | ||
| description: This article describes the role and responsibilities of Consuming Tenant Admin in SharePoint Embedded. | ||
| ms.date: 08/13/2025 | ||
| ms.date: 07/13/2026 |
There was a problem hiding this comment.
Don't update ms.date... this should be set to the page's original creation date and not changed. the rendering engine uses git history for the page to determine last updated date
please revert this
| --- | ||
| title: What's new in SharePoint Embedded? | ||
| description: Updates about Microsoft SharePoint Embedded. | ||
| ms.date: 06/04/2025 |
There was a problem hiding this comment.
don't update ms.date.... leave set to original publish date & let rendering engine determine lastmod from githistory
There was a problem hiding this comment.
merge conflict ... need to reflect changes from previous pr
|
Learn Build status updates of commit 610e5b9: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 00e2844:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/build/sharepoint-embedded-mcp-server.md | View | Details | |
| .openpublishing.redirection.json | ✅Succeeded | View | |
| docs/embedded/admin/admin-overview.md | ✅Succeeded | View | |
| docs/embedded/admin/apply-security-compliance-controls.md | ✅Succeeded | View | |
| docs/embedded/admin/consuming-tenant-admin.md | ✅Succeeded | View | |
| docs/embedded/admin/create-apps-powershell.md | ✅Succeeded | View | |
| docs/embedded/admin/create-apps-sharepoint-admin-center.md | ✅Succeeded | View | |
| docs/embedded/admin/grant-admin-consent-permissions.md | ✅Succeeded | View | |
| docs/embedded/admin/install-sharepoint-embedded-app.md | ✅Succeeded | View | |
| docs/embedded/admin/manage-containers-powershell.md | ✅Succeeded | View | |
| docs/embedded/admin/manage-containers-sharepoint-admin-center.md | ✅Succeeded | View | |
| docs/embedded/admin/monitor-usage-billing-cost.md | ✅Succeeded | View | |
| docs/embedded/admin/review-audit-events.md | ✅Succeeded | View | |
| docs/embedded/admin/setup-billing-microsoft-365-admin-center.md | ✅Succeeded | View | |
| docs/embedded/administration/adminrole.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/billing/billing.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/billing/billingmanagement.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/consuming-tenant-admin/ctapowershell.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/consuming-tenant-admin/ctaUX.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/developer-admin/dev-admin.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/build/agent-experiences.md | ✅Succeeded | View | |
| docs/embedded/build/archive-restore-containers.md | ✅Succeeded | View | |
| docs/embedded/build/configure-authentication-authorization.md | ✅Succeeded | View |
This comment lists only the first 25 files in the pull request.
docs/embedded/build/sharepoint-embedded-mcp-server.md
- Line 28, Column 186: [Warning: file-not-found - See documentation]
Invalid file link: 'containertypes.md'. - Line 136, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: 'spembedded-for-vscode.md'. - Line 137, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: 'containertypes.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Learn Build status updates of commit 5f501bb:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| docs/embedded/build/sharepoint-embedded-mcp-server.md | View | Details | |
| .openpublishing.redirection.json | ✅Succeeded | View | |
| docs/embedded/admin/admin-overview.md | ✅Succeeded | View | |
| docs/embedded/admin/apply-security-compliance-controls.md | ✅Succeeded | View | |
| docs/embedded/admin/consuming-tenant-admin.md | ✅Succeeded | View | |
| docs/embedded/admin/create-apps-powershell.md | ✅Succeeded | View | |
| docs/embedded/admin/create-apps-sharepoint-admin-center.md | ✅Succeeded | View | |
| docs/embedded/admin/grant-admin-consent-permissions.md | ✅Succeeded | View | |
| docs/embedded/admin/install-sharepoint-embedded-app.md | ✅Succeeded | View | |
| docs/embedded/admin/manage-containers-powershell.md | ✅Succeeded | View | |
| docs/embedded/admin/manage-containers-sharepoint-admin-center.md | ✅Succeeded | View | |
| docs/embedded/admin/monitor-usage-billing-cost.md | ✅Succeeded | View | |
| docs/embedded/admin/review-audit-events.md | ✅Succeeded | View | |
| docs/embedded/admin/setup-billing-microsoft-365-admin-center.md | ✅Succeeded | View | |
| docs/embedded/administration/adminrole.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/billing/billing.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/billing/billingmanagement.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/billing/meters.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/consuming-tenant-admin/cta.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/consuming-tenant-admin/ctapowershell.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/consuming-tenant-admin/ctaUX.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/administration/developer-admin/dev-admin.md | ✅Succeeded | n/a (file deleted or renamed) | |
| docs/embedded/build/agent-experiences.md | ✅Succeeded | View | |
| docs/embedded/build/archive-restore-containers.md | ✅Succeeded | View | |
| docs/embedded/build/configure-authentication-authorization.md | ✅Succeeded | View |
This comment lists only the first 25 files in the pull request.
docs/embedded/build/sharepoint-embedded-mcp-server.md
- Line 28, Column 186: [Warning: file-not-found - See documentation]
Invalid file link: 'containertypes.md'. - Line 136, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: 'spembedded-for-vscode.md'. - Line 137, Column 3: [Warning: file-not-found - See documentation]
Invalid file link: 'containertypes.md'.
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Learn Build status updates of commit c08572d: ✅ Validation status: passed
This comment lists only the first 25 files in the pull request. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
3 participants
Summary
Scope
Validation
git diff --checkandgit diff --cached --check.