chore(deps): bump TelnetNegotiationCore 2.5.2 → 2.5.3#17
Merged
Conversation
2.5.3 fixes client-side NAWS (RFC 1073): the client now offers WILL NAWS and only sends an SB NAWS window-size update once the server enables it (DO NAWS). Previously the client sent an unsolicited SB NAWS, which made SharpMUSH swallow the next line — so typed logins to Convergence intermittently bounced back to the login screen (auto-login, sent before any window-size update, was fine). Bumped in Core, Web, and App. Core + Web build clean; 194 Core tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HHCRc5CJ6595iMzEgYYdQp
There was a problem hiding this comment.
Pull request overview
Updates SharpClient’s Telnet stack dependency to pick up TelnetNegotiationCore’s client-side NAWS negotiation fix (RFC 1073), aligning behavior with the PR description (offer WILL NAWS, only send SB NAWS after DO NAWS) and avoiding the “next line swallowed” parser desync scenario described.
Changes:
- Bumped
TelnetNegotiationCorefrom2.5.2to2.5.3in the Core, Web, and App project files. - Expanded the App project’s inline dependency rationale comment to include the NAWS behavior fix details.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/SharpClient.Web/SharpClient.Web.csproj | Bumps TelnetNegotiationCore package reference to 2.5.3. |
| src/SharpClient.Core/SharpClient.Core.csproj | Bumps TelnetNegotiationCore package reference to 2.5.3. |
| src/SharpClient.App/SharpClient.App.csproj | Bumps TelnetNegotiationCore to 2.5.3 and updates the explanatory comment to include the NAWS fix context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in TelnetNegotiationCore 2.5.3 — the client NAWS fix (TNC #51).
Why
2.5.3 fixes client-side NAWS (RFC 1073). The client now offers
WILL NAWSand only sends anSB NAWSwindow-size update once the server enables it withDO NAWS. Previously it sentIAC DO NAWS(wrong direction) plus an unsolicitedSB NAWS, which desynced SharpMUSH's telnet parser and made it swallow the following line — so typed logins to Convergence intermittently bounced back to the login screen (auto-login, sent before any window-size update, was unaffected). Verified live: a NAWS update immediately followed by a login line is now parsed, not swallowed.Bonus: NAWS now actually negotiates, so the server learns the real column width (what the recent wrap/MinColumns work needs).
Changes
TelnetNegotiationCore2.5.2→2.5.3inSharpClient.Core,SharpClient.Web,SharpClient.App.Verification
SharpClient.CoreandSharpClient.Webbuild clean against 2.5.3.Together with #16 (2.5.2, CHARSET fix), this closes out the login-swallow issues on Convergence.
🤖 Generated with Claude Code