Add Fulfillment option generator function templates - #416
Open
otheriault wants to merge 6 commits into
Open
Conversation
Add Rust, JavaScript/TypeScript, and Wasm templates for the cart.fulfillment-options.generate function, following the established pickup-point-delivery-option-generators pattern (optional fetch target + run target with external HTTP access). - functions-fulfillment-option-generators-rs (shopify_function 2.1.0) - functions-fulfillment-option-generators-js (vanilla-js + typescript) - functions-fulfillment-option-generators-wasm - templates.json: register under "Functions", gated by organizationExpFlags Each flavor mirrors pickup-point structure: schema.graphql, fetch/run input queries, the language-agnostic vitest fixture harness, and locales. Assisted-By: devx/afb31d94-b8e2-4abe-ad93-cc5236235202
Re-sync the fulfillment-option-generator templates (rs/js/wasm) to the
current `unstable` schema dumped from shop/world, picking up the
"Remove time periods from FOG V1 function API" change plus prior drift:
- schema.graphql: copied from world's FOG dump (header normalized to
`# api_version: unstable`). Drops the `timePeriod` field, the
`TimePeriod`/`TimePoint` inputs, the `Duration` scalar, and the now
unused `@oneOf` directive; renames result types to
`CartFulfillmentOptionsGenerate{Fetch,Run}Result`; adds `Customer.createdAt`.
- rs: update run/fetch to the new result type names, drop the stale
`time_period: None` and the orphaned `Duration` scalar alias, and
remove `"timePeriod": null` from the README example and fixtures.
- js/ts: update the imported/returned result type names and README.
Verified: `functions-fulfillment-option-generators-rs` vitest passes
(5/5); graphql-codegen emits the new TS type names; all three schemas
are byte-identical to world below the header.
Assisted-By: devx/4b834766-2323-4549-8b8e-b7b957c22829
otheriault
force-pushed
the
ot.fulfillment-option-generator-templates
branch
from
August 5, 2026 12:51
4a3d900 to
a4a99e1
Compare
The function-runner shipped with current @shopify/cli omits absent nullable output fields rather than emitting them as null. Rust's None serializes to an omitted key, so the expected outputs must not assert null values. Mirrors the same alignment done for functions-discount-rs in 6ee908d. The JS fixtures intentionally keep their nulls, since the JS template emits them explicitly (cost: null, address2: null, ...). Assisted-By: devx/46d23b6a-3c26-475d-9754-08333a1083b3
Pull the current unstable fulfillment option generator schema. The only change versus the committed copy is the rename of FulfillmentOptionsAddOperation.destinationServicePointHandle to destinationHandle, plus the doc comments referencing it. Updates all three flavors' schema.graphql and the code/fixtures/READMEs that reference the field. Assisted-By: devx/46d23b6a-3c26-475d-9754-08333a1083b3
Commit 1679dd5 swept in pnpm-lock.yaml / pnpm-workspace.yaml generated by a local `pnpm install` across the workspace: 26 files and ~17.8k lines added to 13 unrelated Rust templates plus the repo root. None of these exist on main. This repo deliberately does not commit lockfiles (.gitignore already lists yarn.lock, package-lock.json and Cargo.lock); pnpm-lock.yaml was simply absent from that list because nothing used pnpm before this branch. The generated pnpm-workspace.yaml files were also placeholder stubs ("set this to true or false"). Drop all of them and add both pnpm files to .gitignore so this cannot recur. Assisted-By: devx/46d23b6a-3c26-475d-9754-08333a1083b3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds new function templates for the Fulfillment option generator (
cart.fulfillment-options.generate), following the establishedpickup-point-delivery-option-generatorspattern.Three template directories (one
-jscovers both vanilla JS and TypeScript via Liquid flavor switches):functions-fulfillment-option-generators-rs— Rust (shopify_function 2.1.0)functions-fulfillment-option-generators-js— JavaScript + TypeScriptfunctions-fulfillment-option-generators-wasm— Wasm placeholderRegistered in
templates.jsonunder the Functions group, gated behind an Experiments Platform flag viaorganizationExpFlags.Targets
Mirrors the pickup-point fetch + run pattern:
cart.fulfillment-options.generate.fetch— returns an external HTTP request (only when the buyer's country is Canada in this demo).cart.fulfillment-options.generate.run— parses the response and emitsfulfillmentOptionsAddoperations, with providers/service points deduplicated into thereferencesblock.To simulate an external API, the demo reuses the existing hosted pickup-points JSON file.
Structure parity
Each flavor matches the current pickup-point convention:
schema.graphql, fetch/run input queries, the language-agnostic vitest fixture harness (tests/default.test.js+tests/fixtures/*.json), locales, and.liquidsource.Testing
Validated locally:
expand-liquidfor rust / vanilla-js / typescript / wasmcargo fmt --check,cargo clippy -- -D warnings,cargo build --release --target wasm32-unknown-unknowngraphql-codegentypegen passes (queries validate against the schema; all generated types resolve)Follow-ups (out of this repo)
templates.jsonafter merge