Refactor/587 composite actions#795
Open
Code-Paragon wants to merge 4 commits into
Open
Conversation
|
@Code-Paragon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #587 by restructuring the repository's duplicated workflow configurations into clean, modular, and reusable composite actions.
Linked Issue
Closes #587
Type of Change
Changes Made
.github/actions/:setup-node: Handles checkout, Node environment provisioning, dependency caching, and environment initialization.build-contracts: Sets up the Rust toolchain, configures the WASM target, installs the Soroban CLI, and handles binary artifacts.run-tests: Standardizes test execution flags.deploy-service: Orchestrates deployment steps (Docker build, container registry push, and Helm rollbacks)..github/workflows/test-actions.yml) to validate the composite actions locally and on pull requests.audit-ci.jsonto prevent unrelated audit breaks.While the composite action architecture and YAML syntax are fully correct, the workflow runs encounter blocking errors originating from pre-existing, broken upstream code on
main:jest-junit): The test command invokes--reporters=jest-junit, butjest-junitis absent frompackage.json'sdevDependencies.contracts/fail to compile due to upstream macro panics (LengthExceedsMax), type mismatches (u64vsu32inmerkle.rs), and unfulfilled trait bounds (TopicsforSymbol).Fixing these upstream application bugs and missing dependency declarations falls entirely outside the scope of a CI architecture restructuring PR.
Pull Request Checklist
Quality Gates
jest-junitreporter packagemainAdditional Requirements