Skip to content

feat(notification): implement subscription webhook system with event filtering and retry (#727)#802

Open
primexk5 wants to merge 1 commit into
Smartdevs17:mainfrom
primexk5:feat/727-subscription-webhook-system
Open

feat(notification): implement subscription webhook system with event filtering and retry (#727)#802
primexk5 wants to merge 1 commit into
Smartdevs17:mainfrom
primexk5:feat/727-subscription-webhook-system

Conversation

@primexk5

Copy link
Copy Markdown

Closes #727

What Was Built

A production-ready subscription webhook system covering all acceptance criteria from Issue #727.

Key Changes

  • Wildcard Event Filtering: Enhanced isWebhookEventAllowed to support pattern matching (*, subscription.*, etc.) using EventCatalogRegistry.
  • Unified Service Barrel: Created backend/services/notification/webhooks.ts as specified in the issue Technical Scope, re-exporting delivery services, REST API wrappers, helpers, and event schema/catalog.
  • Webhook Testing Tools: Added testWebhook method to WebhookDeliveryService and WebhookManagementApi for simulating deliveries with realistic schema-generated payloads, bypassing idempotency and rate limits for development/testing.
  • Interface & Exports: Updated IWebhookDeliveryService with all implemented methods (rotateSecret, listDeadLetters, replayDeadLetter, cleanupDeadLetters, cleanupExpiredIdempotencyKeys, testWebhook) and exported WebhookManagementApi from root services index.
  • Documentation: Fully rewritten developer guide (developer-portal/docs/webhook-guide.md) covering 30+ event types, wildcard syntax, HMAC signature verification without timestamp wrapping, retry schedules, DLQ, and CRUD reference.
  • Unit Tests: Added 8 new unit tests in webhook.test.ts covering wildcard filtering, exponential backoff calculations, and test delivery simulation.

@drips-wave

drips-wave Bot commented Jul 26, 2026

Copy link
Copy Markdown

@primexk5 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build subscription webhook system with event filtering and retry

1 participant