Clean up PPR sampler naming#707
Merged
Merged
Conversation
mkolodner-sc
requested review from
kmontemayor2-sc,
nshah-sc,
svij-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
July 15, 2026 18:54
This was referenced Jul 15, 2026
mkolodner-sc
force-pushed
the
mkolodner-sc/pr701-ppr-cleanup
branch
3 times, most recently
from
July 15, 2026 21:40
19c0d92 to
f7aec06
Compare
kmontemayor2-sc
approved these changes
Jul 15, 2026
yliu2-sc
approved these changes
Jul 15, 2026
mkolodner-sc
force-pushed
the
mkolodner-sc/pr701-ppr-cleanup
branch
3 times, most recently
from
July 16, 2026 19:21
68d6d62 to
3d34854
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
mkolodner-sc
force-pushed
the
mkolodner-sc/pr701-ppr-cleanup
branch
from
July 16, 2026 20:01
3d34854 to
f5c430d
Compare
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Splits out behavior-neutral PPR sampler cleanup ahead of the typed-PPR changes.
This PR intentionally does not change PPR sampling behavior. It renames local variables and tightens nearby comments/docstrings in
DistPPRNeighborSamplerso the follow-up PRs can focus on event-loop performance and typed-channel behavior.Stack
mkolodner/ppr-residual-topup)Reasoning for Change
The typed-PPR work touches a lot of code in the distributed PPR sampler. Pulling readability cleanup into its own PR makes the business-logic diffs easier to review and keeps later review comments focused on the functional changes.
Changes