#769 Header component#817
Draft
NoelDeMartin wants to merge 6 commits into
Draft
Conversation
- Update dependencies range to dev prereleases - Move tailwindcss to devDependencies (reset CSS is bundled in dist) - Remove React dependencies (no longer needed for Storybook 10)
- Reuse babel config from solidos-toolkit - Replace closeBundle usage with generateBundle emits - Fix storybook TS config - Use bundler module resolution
Only 0.01% of our target browsers don't support it (KaiOS and Opera Mini), so it's not worth adding any polyfills. However, these changes make it at least usable on these browsers given that a <dialog> will be rendered as a plain unknown element instead of crashing.
Prompts: - Looking at https://github.com/shoelace-style/webawesome/blob/next/packages/webawesome/src/components/select/select.ts, can you update the Combobox component to be accessible? Also, replace the popup and anchor CSS positioning by using Web Awesome's popup instead (wa-popup). - Can you review the ARIA guidelines for our current implementation? https://www.w3.org/WAI/ARIA/apg/patterns/combobox/ AI Summary of the work: - Replaced native popover and CSS anchor positioning with wa-popup - Added combobox ARIA roles, states, and keyboard navigation - Aligned aria-selected, labeling, and keyboard behavior with APG guidelines - Close popup on outside click or focus, Escape, Tab, and empty filter results - Added label ids in InputTrait for aria-labelledby Co-Authored-By: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.