SONARPHP-1889 Add null checks to prevent NPE and suppress warning#1767
Merged
Conversation
Contributor
|
roberto-orlandi-sonarsource
requested a review
from karim-ouerghemmi-sonarsource
July 16, 2026 15:57
karim-ouerghemmi-sonarsource
approved these changes
Jul 17, 2026
karim-ouerghemmi-sonarsource
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Code Review ✅ ApprovedAdds null checks and nullable annotations to OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Gitar |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Part of
Summary by Gitar
@Nullableannotations and explicit null checks toTokenVisitormethodsprevTokenandnextToken.ControlStructureSpacingCheckhelper methods to handle null tokens gracefully.PHPGrammarwith@SuppressWarnings.TokenVisitorTestto verify token navigation logic and edge cases including null inputs.This will update automatically on new commits.