feat: implement issues #559, #560, #561, #562 - #571
Open
adeniran19-maker wants to merge 2 commits into
Open
Conversation
…split#561, Stellar-split#562 - Stellar-split#559 Creator Revenue Share: add creator_fee_bps to InvoiceOptions2/Invoice, validate fee cap in _create_invoice_inner, deduct creator fee in release paths, emit creator_fee_paid event - Stellar-split#560 Creator Migration: add nominate_new_creator/accept_creator_role entry points, pending_creator_key storage, creator_nominated/creator_migrated events - Stellar-split#561 Payout Ordering: add sort_recipients in calc.rs, emit payout_initiated events with recipient index during release - Stellar-split#562 Soft-Delete with Tombstone: add Tombstone type, delete_invoice/get_tombstone entry points, tombstone_key storage, InvoiceDeleted/FundsUnclaimed/NotDeleted guards, and invoice_state_changed updates Closes Stellar-split#559, Stellar-split#560, Stellar-split#561, Stellar-split#562
|
@adeniran19-maker Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements four feature issues in the Split Contract:
creator_fee_bpstoInvoiceOptions2/Invoice, validates the combined fee cap in_create_invoice_inner, deducts the creator fee in_release_fulland_release_tranches, and emitscreator_fee_paidevents.nominate_new_creator/accept_creator_roleentry points,pending_creator_keystorage, andcreator_nominated/creator_migratedevents.sort_recipientsincalc.rsfor canonical address ordering, and emitspayout_initiatedevents with recipient index during release.Tombstonetype,delete_invoice/get_tombstoneentry points,tombstone_keystorage,InvoiceDeleted/FundsUnclaimed/NotDeletedguards, andinvoice_state_changedupdates.Files Changed
contracts/split/src/types.rscontracts/split/src/error.rscontracts/split/src/events.rscontracts/split/src/storage_keys.rscontracts/split/src/calc.rscontracts/split/src/lib.rscontracts/split/src/test.rsTesting
test.rs.maincurrently has a pre-existing unclosed-delimiter compilation failure inlib.rs(claim_delayed_payout/paybodies). This PR includes minimal structural fixes so the new feature code can compile, but those pre-existing issues are not the focus of this PR.Closing Issues
Closes #559, Closes #560, Closes #561, Closes #562