Feature/issues 528 529 530 531 - #578
Merged
Kingsman-99 merged 4 commits intoJul 30, 2026
Merged
Conversation
|
@DNight-King Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Branch feature/issues-528-529-530-531 (local only, not pushed) has 4 commits, one per issue:
Closes #528 — src/accountDataManager.ts: AccountDataManager CRUD wrapper over manageData, with DataEntryValidationError, AccountDataEntry/AccountDataMap types, and a txBuilder.addManageData() integration point.
Closes #529 — src/sorobanFeatureDetector.ts: SorobanFeatureDetector reading protocol version + Soroban resource limits, cached with configurable staleness, emitting protocolUpgradeDetected; wired into client.ts via getSorobanFeatures().
Closes #530 — src/streamDeduplicator.ts: circular-buffer paging-token dedup with persistence hooks added to snapshot.ts, optionally pluggable into sse.ts/stream.ts without changing default behavior.
Closes #531 — AuditLogger.recordSplitLeg() / exportSplitAuditTrail() plus a CSV exporter in complianceExporter.ts.
I verified with tsc --noEmit at every step that none of these changes add new type errors — the repo already has ~125 pre-existing errors (missing exports in cursorTracker.ts/errors.ts, etc.) unrelated to this work, confirmed by diffing before/after each commit.
One heads-up: issue #531 references src/paymentProgressTracker.ts and SplitLeg/SplitResult types that don't actually exist in the repo yet, so I exposed recordSplitLeg() as a method callers invoke directly rather than inventing that missing infrastructure — flagged in the PR description.