feat: fix y-websocket typing (#972) and implement BullMQ DLQ with ret… - #1008
Open
melvilmz wants to merge 1 commit into
Open
feat: fix y-websocket typing (#972) and implement BullMQ DLQ with ret…#1008melvilmz wants to merge 1 commit into
melvilmz wants to merge 1 commit into
Conversation
|
@melvilmz is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@melvilmz Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR resolves issues #972 and #989 by addressing TypeScript typing for
y-websocketand introducing a Dead-Letter Queue (DLQ) with exponential backoff retries for background jobs.🚀 Key Improvements
1. Proper Typing for
y-websocket(#972)src/types/y-websocket.d.ts) coveringy-websocket/bin/utils.src/collaborationServer.tsto cleanly importsetupWSConnectionwithout requiring@ts-expect-error.2. BullMQ Dead-Letter Queue & Retries (#989)
src/services/dlq.service.ts):traceId), error messages, timestamps, and attempt counts.DLQ_ALERT_THRESHOLD).src/routes/admin/dlq.routes.ts):GET /admin/dlq: Inspect DLQ records (supports optionalqueuefilter &limit).GET /admin/dlq/metrics: Retrieve DLQ count metrics & alert status.POST /admin/dlq/replay/:dlqId: Replay a specific job back to its original queue.POST /admin/dlq/replay: Replay all jobs (or jobs for a target queue).POST /admin/dlq/purge: Purge DLQ jobs.tests/dlq.test.ts):🧪 Acceptance Criteria Checklist
collaborationServer.tscompiles without@ts-expect-errortraceIdRelated Issues