test(web): add deterministic Drand countdown boundary tests - #186
Open
ogundeleoluwaferanmi35 wants to merge 1 commit into
Open
test(web): add deterministic Drand countdown boundary tests#186ogundeleoluwaferanmi35 wants to merge 1 commit into
ogundeleoluwaferanmi35 wants to merge 1 commit into
Conversation
Extract a pure computeCountdown helper that accepts target round, current time, genesis, and period, making the countdown calculation deterministic and testable. Reuse it in both localCountdown (offline quicknet fallback) and the live chain info path inside useDrandCountdown. Tests cover one second before R, exactly at R, after R, published rounds, future rounds, and formatCountdown boundary cases (seconds/minutes/hours). Closes Sub-Rosa-Issue#174
|
@ogundeleoluwaferanmi35 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extract the Drand countdown calculation into a pure `computeCountdown` helper and add deterministic boundary tests with fixed timestamps.
What changed
Key design decisions
Acceptance criteria checklist
Test output
```
ℹ tests 64
ℹ pass 64
ℹ fail 0
ℹ duration_ms 6719.737373
```
Typecheck
`pnpm --filter @sub-rosa/web typecheck` passes cleanly.
Closes #174