Binary edit: add IMSC 1.1 image profile to the Export menu#12548
Merged
Conversation
Wire the ExportHandlerImscImage into the binary/image subtitle editor's File > Export menu (window menu + native macOS menu), alongside the existing Blu-ray SUP / BDN XML / FCP / VobSub exporters. Writes a single .ttml file; the binary sub's own bitmaps and X/Y placement flow straight through DoExport (which sets OverridePosition), so cues keep their original on-screen position with no re-rendering. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #12547: also offer the IMSC 1.1 image profile export from the binary/image subtitle editor (BinEdit), where PGS/VobSub/etc. are edited.
Adds an
ExportImscImagecommand that runs the already-mergedExportHandlerImscImagethrough the sharedDoExportflow, and wires it into both the window menu and the native macOS menu alongside Blu-ray SUP / BDN XML / FCP / VobSub.Because BinEdit exports the binary sub's own bitmaps and passes each cue's real X/Y via
OverridePosition, the IMSC regions keep the original on-screen placement — no re-rendering. Output is a single self-contained.ttmlfile (same conformant shape covered by #12547's tests, which round-trips through SE's Timed Text Base64 Image reader).UI builds clean.
🤖 Generated with Claude Code