Point sync: sorted points, working delete, button icon; fix file name overflow#12552
Merged
Conversation
… overflow Apply the same fixes to "Point sync" as "Point sync via other subtitle" got in 0ae5380: - Sync points stay in chronological order, and setting a point for a line that already has one re-points it instead of adding a duplicate. - Deleting a sync point works: the Delete menu item is now actually in the context flyout (disabled without a selection) instead of the Opening handler deleting silently, the grid binds its selection to SelectedSyncPoint, and Delete/Backspace on the grid also removes the selected point. - "Set sync point" button gets the left/right arrows icon. Also in "Point sync via other subtitle": a long file name in the right header sat in a horizontal StackPanel and overflowed under the "Find text" button; it is now a TextBlock in a star column that auto-shrinks with a character ellipsis. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the same fixes to Point sync that Point sync via other subtitle got in #12529:
SelectedSyncPoint, and Delete/Backspace on the grid also removes the selected point.Also in Point sync via other subtitle: a long file name in the right header sat in a horizontal StackPanel and overflowed under the "Find text" button — it is now a TextBlock in a star column that auto-shrinks with a character ellipsis.
🤖 Generated with Claude Code