Hide "Download yt-dlp" button in Open from URL when already up to date#12559
Merged
Conversation
The button was always visible, even with the latest yt-dlp installed. Now it is hidden by default and only shown when the background version check finds the installed yt-dlp outdated. After a successful update via the button it hides again, and the post-submit "outdated" prompt is skipped when the user already updated through the button. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Lets the user save the selected downloaded subtitle file as-is (plain copy, no format conversion) to a chosen location — the downloaded files live in a temp directory that is deleted right after the picker closes. Mirrors the export button in the Matroska track picker. The save-as suggestion uses a video-derived name with language code instead of the temp-dir "sub.en.vtt" naming. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
niksedk
force-pushed
the
fix/open-from-url-ytdlp-button
branch
from
July 17, 2026 07:38
15cb888 to
e77eac3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The "Open video from URL" window always showed a "Download yt-dlp" button, even when the latest yt-dlp was already installed.
Fix
yt-dlp --versionoutdated-check (which already runs while the dialog is open) reports the install as outdated.Note: when yt-dlp is missing entirely, the install prompt already blocks before this window opens, so the always-visible button never had a purpose in the up-to-date case.
Also: "Save..." button in the online subtitle picker
The "Pick subtitle to download" window now has a "Save..." button (mirroring the export button in the Matroska track picker) that saves the selected downloaded subtitle file as-is (plain copy, no format conversion) to a user-chosen location. Needed because the downloaded files live in a temp directory that is deleted right after the picker closes. The save-as suggestion uses a video-derived name with language code (e.g.
MyVideo.en.vtt) instead of the temp-dirsub.en.vttnaming.🤖 Generated with Claude Code