Fix console color resource references and AutoJs singleton in LogBottomSheet#556
Draft
djbclark wants to merge 2 commits into
Draft
Fix console color resource references and AutoJs singleton in LogBottomSheet#556djbclark wants to merge 2 commits into
djbclark wants to merge 2 commits into
Conversation
Replace AutoJs.getInstance() (nullable, null-guarded) with AutoJs.instance (non-null) since the bottom sheet only opens after app initialization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small fixes in the log bottom sheet:
XML layout: Change
@color/console_debug→@color/console_view_debugand@color/console_verbose→@color/console_view_verbose— the old names referenced colors that don't exist, causing the console to render with default colors.Kotlin: Change
AutoJs.getInstance()(nullable, null-guarded) toAutoJs.instance(non-null). The bottom sheet only opens from the main UI after AutoJs is initialized, so the null check was unnecessary defensive code — and the inner block was skipped entirely in practice.Neither change is breaking. Tested on the fleet-profile fork build.
Thank you for maintaining this project — it's incredibly useful.