Funogram 3.0.5 / Telegram 10.2.0: unwind ChatMember + JSON-options workarounds#211
Merged
Conversation
…rkarounds Funogram 3.0.5 fixes the DU converter misdiscrimination (status now picks the ChatMember case, via Always-attribute discriminators — upstream refactoring of our PR Dolfik1/Funogram#93) and exposes Funogram.Tools.options publicly (Dolfik1/Funogram#95). - FunogramJson (BotInfra) and SerializationCompat fixtures use the public Funogram.Tools.options instead of reflection over the internal field - CouponHubBot membership check branches on ChatMember DU cases instead of wire-status strings; same member set as before (creator/admin/member) - Drop the "NEVER branch on ChatMember DU cases" warnings and vahter's now-unused chatMemberStatus helper - FakeTgApiSpikeTests now asserts correct case discrimination instead of characterizing the 3.0.4 bug Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Pins the Funogram 3.0.5 fix production now relies on. Verified red on 3.0.4 (member/left/kicked all deserialized as ChatMember.Owner) and green on 3.0.5. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Szer
enabled auto-merge (squash)
July 16, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Funogram 3.0.5 ships the ChatMember DU discriminator fix (upstream refactoring of our Dolfik1/Funogram#93, via
Always-attribute discriminators) and makesFunogram.Tools.optionspublic (Dolfik1/Funogram#95). This unwinds both workarounds:Reflection over JSON options
BotInfra.FunogramJsonandSerializationCompat.Tests/Fixtures.fsnow use the publicFunogram.Tools.optionsinstead of aBindingFlags.NonPublicreflection grab.ChatMember DU misdiscrimination
ChatMemberDU cases (Owner | Administrator | Member) instead of wire-status strings — same member set as before.chatMemberStatushelper (chatMemberUserstays — it's plain field extraction).FakeTgApiSpikeTestsflipped from characterizing the 3.0.4 bug to asserting{"status":"member"}→ChatMember.Member.ChatMemberCompatTeststheory pins discrimination for all six wire statuses through the real Funogram options.Verification
dotnet build: clean, 0 warnings (Bot API 10.2 type changes absorbed).dotnet fsiagainst Funogram 3.0.4:member/left/kickedall deserialized asChatMember.Owner; the new theory passes on 3.0.5.🤖 Generated with Claude Code