-
Notifications
You must be signed in to change notification settings - Fork 0
feat(official): CMS138 onboarded — 0/47 → 47/47, and the gate learned a new kind of claim #366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
93e98b0
feat(official): onboard CMS138 — the absent value set is sourced, dec…
225932d
docs(official): ADR-053's "the MADiE gate is the oracle" is FALSE for…
fd6bfdd
feat(official): the gate supplements ONLY the value sets upstream doe…
b79a389
fix(official): wire the supplement through the CLI and make the allow…
bffec21
feat(official): CMS138 is onboarded — 0/47 → 47/47, gate now 278/278 …
895027d
fix(official): an uncredentialed fork PR would have gone unconditiona…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| { | ||
| "catalogId": "cms138", | ||
| "measureName": "CMS138FHIRTobaccoScrnCessation", | ||
| "version": "1.0.000", | ||
| "cmsId": "138FHIR", | ||
| "url": "https://madie.cms.gov/Measure/CMS138FHIRTobaccoScrnCessation", | ||
| "status": "active", | ||
| "effectivePeriod": { | ||
| "start": "2026-01-01", | ||
| "end": "2026-12-31" | ||
| }, | ||
| "scoring": "proportion", | ||
| "populationBasis": "boolean", | ||
| "improvementNotation": "increase", | ||
| "populations": [ | ||
| "initial-population", | ||
| "denominator", | ||
| "denominator-exclusion", | ||
| "numerator" | ||
| ], | ||
| "source": { | ||
| "repo": "cqframework/dqm-content-qicore-2025", | ||
| "ref": "ca4b49516de4cbed9f92bfb7c35d97b1bf1022ab", | ||
| "path": "bundles/measure/CMS138FHIRTobaccoScrnCessation/CMS138FHIRTobaccoScrnCessation-bundle.json", | ||
| "rawSha256": "sha256:1056b796f19ee79cb76a6c76022f511efcc0e7b6e2fa18c90637ae9669ab9989" | ||
| }, | ||
| "reduction": { | ||
| "keptResourceTypes": [ | ||
| "Measure", | ||
| "Library" | ||
| ], | ||
| "libraryContentTypes": [ | ||
| "application/elm+json" | ||
| ], | ||
| "strippedNarratives": true, | ||
| "strippedElmAnnotations": true, | ||
| "strippedValueSets": true, | ||
| "rawBytes": 15842294, | ||
| "vendoredBytes": 2343564 | ||
| }, | ||
| "terminology": { | ||
| "file": "terminology.json", | ||
| "valueSets": 32, | ||
| "codes": 549, | ||
| "truncated": [], | ||
| "completion": { | ||
| "source": "vsac", | ||
| "manifest": "http://cts.nlm.nih.gov/fhir/Library/ecqm-fhir-update-2025", | ||
| "valueSets": [ | ||
| { | ||
| "oid": "2.16.840.1.113883.3.526.3.1278", | ||
| "reason": "absent-upstream", | ||
| "had": 0, | ||
| "now": 4, | ||
| "declaredTotal": null | ||
| } | ||
| ] | ||
| }, | ||
| "sha256": "sha256:e2f8b334c9b352f419eeaec736ce9b914b384bf7a34f1453d50db458aea417d8" | ||
| }, | ||
| "sha256": "sha256:219b52a38363ac6968d47b0d51b6b45656da6b01a9a9d2496bd05aab25280eb4" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this job runs for a fork or Dependabot PR, GitHub withholds
WORKWELL_VSAC_API_KEY_VENDOR, so lines 170–176 leave$COMPLETEempty. This new invocation then regenerates CMS138 with only the 31 upstream value sets;backend-ts/scripts/vendor-official-measure.mjs:507-515explicitly says that the resulting artifact cannot run because the missing set requires--complete-terminology. The bundle-only reproducibility check still passes, but the workflow subsequently runs the defaultpnpm test:official-casesgate at lines 232–234, which now includes CMS138 and therefore reports all 47 cases as errors and exits nonzero. Condition the CMS138 invocation/gate for the uncredentialed path or otherwise provide a credentialless way to retain its validated supplement, so every external PR is not unconditionally red.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct and fixed in
895027d— thank you, this would have turned every external contributor's PR red on merge.Your trace is exactly right: uncredentialed →
$COMPLETEempty → cms138 re-vendored with only upstream's 31 value sets → the supplement has nothing to draw on → 47 errors → nonzero exit. And the bundle-only reproducibility check passes, so nothing upstream of the gate would have caught it.--allow-missing-terminologyskips a measure the CONTEXT cannot resolve, passed by CI only wheresteps.vendor.outputs.credentialed != 'true'— the same conditional the reproducibility check already splits on, and the same shapeofficial-flip-config.test.tsuses to excuse the capped class.The opt-OUT is the load-bearing half, so it is the one I pinned hardest: a credentialed run passes nothing and therefore skips nothing, because there an unresolvable value set means a broken artifact — which is the whole point of the gate. There is a test that supplies the SAME unresolvable OID without the flag and asserts the measure still runs, so the accommodation cannot quietly become the default.
Two consequences your comment did not have to reach, both handled:
--measureguard rather than adding a second one.The skip predicate is
absentValueSets(artifact, requiredOids(artifact))— the same oneofficialRoutingProblemsrefuses on — so "the gate skipped it" and "routing would refuse it" are one decision, not two that can drift.Mutation-checked both ways: skipping regardless of the flag, and letting a partial run overwrite the report, each fail exactly one test.