Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 63 additions & 1 deletion packages/react-store/tests/index.test.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import { act, render, renderHook, waitFor } from '@testing-library/react'
import { Suspense, startTransition, use, useState } from 'react'
import {
act,
fireEvent,
render,
renderHook,
waitFor,
} from '@testing-library/react'
import { userEvent } from '@testing-library/user-event'
import { describe, expect, it, test, vi } from 'vitest'
import { createAtom, createStore } from '@tanstack/store'
Expand Down Expand Up @@ -141,6 +148,61 @@ describe('atom hooks', () => {
expect(getByText('Renders: 2')).toBeInTheDocument()
})

it('useSelector keeps the committed selector active while a selector change suspends', async () => {
const atom = createAtom({ a: 0, b: 0 })
const never = new Promise<never>(() => {})

const selectA = (state: { a: number; b: number }) => state.a
const selectB = vi.fn((state: { a: number; b: number }) => state.b)

function Value({ mode }: { mode: 'a' | 'b' }) {
const value = useSelector(atom, mode === 'a' ? selectA : selectB)

// Suspend only after useSelector has rendered with the pending selector.
if (mode === 'b') {
use(never)
}

return <output data-testid="value">A:{value}</output>
}

function Comp() {
const [mode, setMode] = useState<'a' | 'b'>('a')

return (
<>
<button
type="button"
onClick={() => startTransition(() => setMode('b'))}
>
Switch
</button>
<Suspense fallback={<p>Loading</p>}>
<Value mode={mode} />
</Suspense>
</>
)
}
Comment thread
crutchcorn marked this conversation as resolved.

const { getByRole, getByTestId } = render(<Comp />)

expect(getByTestId('value')).toHaveTextContent('A:0')

fireEvent.click(getByRole('button', { name: 'Switch' }))

// The transition reached selectB but did not commit because it suspended.
await waitFor(() => expect(selectB).toHaveBeenCalled())
expect(getByTestId('value')).toHaveTextContent('A:0')

// Emulate a change to the atom while the transition is suspended.
act(() => {
atom.set({ a: 1, b: 0 })
})

// The committed selectA subscription must observe the synchronous update.
expect(getByTestId('value')).toHaveTextContent('A:1')
})

it('useAtom returns the current value and setter', () => {
const atom = createAtom(0)
const { result } = renderHook(() => useAtom(atom))
Expand Down
Loading