perf: compute NODE_ENV up-front & flip opt-in - #6445
Conversation
The code published to npm still contains the `NODE_ENV` guards. If you're running this code in an env where that isn't set, or where it is `production`, you pay the cost _per call_ of the string comparison. We can avoid that by computing it up front since the env won't change. Then we instead have `if (IS_DEV)` rather than `if (process.env.NODE_ENV === ...)`. Additionally, many of these guards were previously on `=== 'development'`. This meant only something like vite in dev mode would see useful errors (since most other tools won't set NODE_ENV at all). If we flip this around to `!== 'production'`, it means all dev runtimes would get the more useful error messages.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@43081j Every time I've tried to add code like this in a centralized way in the past around |
2 participants
The code published to npm still contains the
NODE_ENVguards. If you're running this code in an env where that isn't set, or where it isproduction, you pay the cost per call of the string comparison.We can avoid that by computing it up front since the env won't change.
Then we instead have
if (IS_DEV)rather thanif (process.env.NODE_ENV === ...).Additionally, many of these guards were previously on
=== 'development'. This meant only something like vite in dev mode would see useful errors (since most other tools won't set NODE_ENV at all). If we flip this around to!== 'production', it means all dev runtimes would get the more useful error messages.DRAFT until we agree that its ok to flip the flag
✅ Checklist
pnpm test:pr.