Fix type annotations in test_flow_core#570
Open
thierry-martinez wants to merge 1 commit into
Open
Conversation
This commit removes the `# type: ignore[misc]` pragma from `test_flow_core`. It introduces a new `PatternTestCase` class, derived from `XZCorrectionsTestCase`, to refine the type of the `flow` field when the `pattern` field is present.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #570 +/- ##
=======================================
Coverage 90.58% 90.58%
=======================================
Files 49 49
Lines 7481 7481
=======================================
Hits 6777 6777
Misses 704 704 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
# type: ignore[misc]pragma fromtest_flow_core. It introduces a newPatternTestCaseclass, derived fromXZCorrectionsTestCase, to refine the type of theflowfield when thepatternfield is present.