fix(skill-nudge): log swallowed errors in debug mode#284
Open
yuhaouno wants to merge 1 commit into
Open
Conversation
|
✅ This PR is linked to an issue assigned to @yuhaouno — thanks! The |
WalkthroughChangesSkill nudge debug diagnostics
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant CLI as preAction hook
participant Nudge as maybeEmitSkillNudge
participant Probe as isVerifySkillInstalled
participant Output as write sink
CLI->>Nudge: pass debug option
Nudge->>Probe: check skill presence with onReadError
Probe->>Nudge: report managed target read failure
Nudge->>Output: emit debug diagnostic
Nudge->>Output: emit existing skill warning
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds debug-only stderr diagnostics for failed profile lookups and unreadable managed skill targets, while preserving default output and exit status. Wires the parsed global --debug flag into the pre-action nudge. This is the narrow skill-nudge subtask of #186. Verified with full tests, lint, typecheck, and format:check. Closes #285.