fix: default MockTimeSystem to the local time zone#1062
Merged
Conversation
The v7 default picked a random curated local time zone, which broke `DateTime.Now.ToUniversalTime()`: the mocked `DateTime.Now` is stamped `DateTimeKind.Local`, but its `ToUniversalTime()` resolves against the real machine `TimeZoneInfo.Local` (which the mock cannot override), so the round-trip produced a wrong value whenever the mocked zone differed from the machine zone. The parameterless `new MockTimeSystem()` and the options-only constructor now use `TimeZoneInfo.Local`, restoring a correct round-trip by default. A new `TimeProviderFactory.Random(TimeZoneInfo localTimeZone)` overload keeps the random time while letting callers pick the zone; the existing `TimeProviderFactory.Random()` still fuzzes the zone from the curated set for anyone who wants that behavior explicitly.
|
|
This is addressed in release v7.0.1. |
This was referenced Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v7 default picked a random curated local time zone, which broke
DateTime.Now.ToUniversalTime(): the mockedDateTime.Nowis stampedDateTimeKind.Local, but itsToUniversalTime()resolves against the real machineTimeZoneInfo.Local(which the mock cannot override), so the round-trip produced a wrong value whenever the mocked zone differed from the machine zone.The parameterless
new MockTimeSystem()and the options-only constructor now useTimeZoneInfo.Local, restoring a correct round-trip by default. A newTimeProviderFactory.Random(TimeZoneInfo localTimeZone)overload keeps the random time while letting callers pick the zone; the existingTimeProviderFactory.Random()still fuzzes the zone from the curated set for anyone who wants that behavior explicitly.