rcx: add multi-chip extraction pass skeleton - #11034
Merged
maliberty merged 2 commits intoAug 3, 2026
Merged
Conversation
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces initial infrastructure for multi-chip (3D) extraction and SPEF writing by adding the MultiChipExtractor and MultiChipSpefWriter classes, integrating them into the Ext class, and dispatching to them when a hierarchical chip is detected. The review feedback identifies critical safety issues where a null top_chip could lead to a null pointer dereference and application crash in ext.i. Additionally, it is recommended to pass ExtractOptions by const reference in extractMultiChip to avoid unnecessary copying.
Signed-off-by: Arthur Koucher <arthurkoucher@precisioninno.com>
maliberty
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm opening this PR so that we have a place to store the extraction rules file paths. Look at this comment and its PR for more context.
Two new classes:
Ext::MultiChipExtractorwill create parasitics objects inside ODB for all chips and inter-chip bonds.Ext::MultiChipSpefWriterwill write one SPEF for each chip and one SPEF for each bond based on the parasitics objects inside ODB.Type of Change
Impact
None.
Verification
./etc/Build.sh).Related Issues
#11005