Fix SyntaxError and NameError in Python 3 exception handling and annotations#14860
Open
ArnavGarg7 wants to merge 1 commit into
Open
Fix SyntaxError and NameError in Python 3 exception handling and annotations#14860ArnavGarg7 wants to merge 1 commit into
ArnavGarg7 wants to merge 1 commit into
Conversation
algorithms-keeper
Bot
added
enhancement
algorithms-keeper
Bot
removed
the
tests are failing
cclauss
reviewed
Jun 25, 2026
| except httpx.HTTPError, ValueError: | ||
| except httpx.HTTPError: | ||
| return None | ||
| except ValueError: |
Member
There was a problem hiding this comment.
An except clause may name multiple exceptions, for example:
... except RuntimeError, TypeError, NameError:
... pass
https://docs.python.org/3/tutorial/errors.html#handling-exceptions
cclauss
added
awaiting changes
cclauss
requested changes
Jun 25, 2026
cclauss
left a comment
cclauss
left a comment
Member
There was a problem hiding this comment.
What do you get when you run:
python --versionpython3 --version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
This pull request fixes a
SyntaxErrorin exception handling where multiple exception types were separated by a comma without parentheses (e.g.,except httpx.HTTPError, ValueError:). Python 3 strictly requires a tuple for catching multiple exceptions:except (httpx.HTTPError, ValueError):.Additionally, this PR fixes a
NameErrorinmaths/matrix_exponentiation.pyby adding back the requiredfrom __future__ import annotations.Important Note for Maintainers: In the previous PR (#14859),
pre-commit-ci(via formatting or pyupgrade hooks) incorrectly reverted these fixes, causing the PR to show "Zero files changed". To prevent the pre-commit bot from breaking the Python 3 syntax again, I have appended# noqato the modified lines.Checklist: