Adopt uv for dependency management, add ruff and ty#15
Open
Broyojo wants to merge 1 commit into
Open
Conversation
- pyproject.toml replaces requirements.txt; deps managed with uv (uv sync, uv run main.py), lockfile committed for reproducibility - pynput moved from a git PR ref to the released package (>=1.8.2), which includes the Apple Silicon support the pin was for - wmi is now correctly Windows-only via an environment marker - ruff configured (default rules + import sorting) and findings fixed: bare excepts, type() comparisons, unused f-string, import order - ty configured with python-platform = "all" for the platform-guarded code paths; fixed the real findings it surfaced (Qt property kwargs not in stubs, closeEvent override signature, _get_bitrate_mbps returning None for unknown fps values) The remaining ty warning about obs.error is a real bug fixed in #12. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Modernizes the project tooling:
pyproject.toml+ uv replacerequirements.txt. Setup is nowuv syncanduv run main.py/uv run build.py;uv.lockis committed for reproducible installs. README updated.refs/pull/541/head) to the released package (>=1.8.2) — that PR's Apple Silicon support has long since shipped in releases, and the git ref was a liability (branch could disappear, blocked CI caching).wmigets a Windows-only environment marker instead of installing everywhere.except:s,type(x) == ycomparisons, import order, unused f-string prefix.python-platform = "all"so platform-guarded code (os.startfile,ctypes.windll) isn't flagged; fixed the real findings — Qt property kwargs that aren't in the PyQt6 stubs (converted to explicitsetChecked/setCheckablecalls),closeEventoverride signature, and_get_bitrate_mbpsreturningNonefor unlisted fps values instead of falling through to the linear model.Both
uv run ruff check .anduv run ty checknow pass, with one intentional exception: ty still warns aboutobs.errorinobs_client.py— that's a real bug (crash on recent obsws-python) fixed by #12, and the warning disappears once it merges. Nice independent confirmation that the type checker earns its keep.Verified with
uv run python -c "import ducktrack"— the full app package imports cleanly under the locked environment.Notes
Independent of #12/#13/#14 (different files/hunks) — can merge in any order. A
ruff formatpass over the repo is deliberately not included to keep the diff reviewable; happy to do it as a follow-up.🤖 Generated with Claude Code