Implement quota fetch all mode and use actual ranged query#76
Draft
rustybee42 wants to merge 6 commits into
Draft
Implement quota fetch all mode and use actual ranged query#76rustybee42 wants to merge 6 commits into
rustybee42 wants to merge 6 commits into
Conversation
rustybee42
force-pushed
the
hackathon/quota
branch
from
July 15, 2026 11:15
83cf6ef to
b57fa83
Compare
rustybee42
force-pushed
the
hackathon/quota
branch
from
July 15, 2026 11:55
b57fa83 to
3f860cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allfetch mode.With this change, quota performance and user experience should significantly improve. It allows the storage server to use incremental enumeration for ranges and the new "all/automatic" mode, querying only entries that actually exist. The old list query remains, querying exactly the ids specified. The new, default automatic mode doesn't need any configuration, no more id files updated by cronjobs needed.
This should be widely compatible with non-updated storage nodes: The range query handler was implemented before, and "all" would just return nothing. Also the other way around: Previous management always queried by list, which remains intact on the patched storage servers.
There is only one little issue (not breaking change): For ZFS, it depends on the version of installed library on whether the incremental enumeration works or not. While there can be a fallback for the range mode (just use the old "try each id in range"), we can't do that for the "all" mode. In that case, the request will fail and error out. Which should be fine, since all mode is new. Note that for ext4 and xfs, this doesn't really apply because it comes with the kernel since 4.6, which includes all our supported kernels.
#72 might not be necessary in this form anymore. Maybe with an only slightly increased timeout.
Related to https://github.com/ThinkParQ/beegfs-core/pull/4756