Phase 1: fail closed across verifier evidence paths#274
Open
pengfei-threemoonslab wants to merge 4 commits into
Open
Phase 1: fail closed across verifier evidence paths#274pengfei-threemoonslab wants to merge 4 commits into
pengfei-threemoonslab wants to merge 4 commits into
Conversation
Expand fail_on_merge_verdicts in both advisory workflows so PRs cannot merge while the verifier reports human review, insufficient evidence, or unknown states. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace the click.utils.strip_ansi dependency with a local helper so the test module loads in CI without a direct click import. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the Phase 1 trustworthy-candidate hardening pass. It makes non-mergeable verifier states operationally fail closed and closes several evidence paths that could previously degrade silently.
Changes
blockedhuman_review_requiredinsufficient_evidenceunknown.mcp.jsonfiles instead of silently returning an empty tool surface.control.next_actionguidance.Validation
sha256:4e03af1348814cdadf9393dd42c41f3606b8209807be578358069628045e1b78Trust and release state
The committed-tree verifier completed successfully, but the candidate is intentionally not mergeable without human review:
control.state = human_review_requiredcontrol.must_stop = truegate.merge_verdict = insufficient_evidenceshipgate.yaml#agent_bindings.rootstill requires a human-reviewed exactsource_idandobjectdeclaration.This PR does not suppress findings, lower severity, expand a baseline/waiver, weaken CI, or invent binding/authority evidence.
Required human action before merge
shipgate.yaml#agent_bindings.root; do not infer or auto-fill them.The resulting verifier artifact remains the authority for merge readiness.