same fixes for neon#1792
Conversation
Performance tests on neon showed the same as the other intrinsics.
remove msvc ninja from the build, it never finishes for some reason
|
FYI the industry practice to disable blocks of code is via #if 0
// ..
// code
// ..
#endif // 0Reason is that |
i get that but as it stands at the moment this will be the same as the other isa expansions, they all need some more vigorous tests and usually these if defs can be switched in in chinks, we would need one for each function ptr being installed if that is the case because this is being tested against other implementations and if 1 of these functions after changes becomes more performant than the scalar it will be uncommented out. Active tests are being run this was just a quick kill all until its figured out |
Performance tests on neon showed the same as the other intrinsics.
The work for all the intrinsics is there just need to go through it with a skeptical eye and see how we can actually increase performance instead of damage it.