Skip to content

same fixes for neon#1792

Open
marauder2k7 wants to merge 2 commits into
TorqueGameEngines:developmentfrom
marauder2k9-torque:Math_neon
Open

same fixes for neon#1792
marauder2k7 wants to merge 2 commits into
TorqueGameEngines:developmentfrom
marauder2k9-torque:Math_neon

Conversation

@marauder2k7

Copy link
Copy Markdown
Contributor

Performance tests on neon showed the same as the other intrinsics.

The work for all the intrinsics is there just need to go through it with a skeptical eye and see how we can actually increase performance instead of damage it.

Performance tests on neon showed the same as the other intrinsics.
remove msvc ninja from the build, it never finishes for some reason
@dottools

Copy link
Copy Markdown
Contributor

FYI the industry practice to disable blocks of code is via #if macro, not block comments, like so:

#if 0
// ..
// code
// ..
#endif // 0

Reason is that #if'd out code shows as disabled, versus commented code just looks like any other comments, in typical code editors / IDEs. Also looks cleaner on diff's to show intention.

@marauder2k7

Copy link
Copy Markdown
Contributor Author

FYI the industry practice to disable blocks of code is via #if macro, not block comments, like so:

#if 0
// ..
// code
// ..
#endif // 0

Reason is that #if'd out code shows as disabled, versus commented code just looks like any other comments, in typical code editors / IDEs. Also looks cleaner on diff's to show intention.

i get that but as it stands at the moment this will be the same as the other isa expansions, they all need some more vigorous tests and usually these if defs can be switched in in chinks, we would need one for each function ptr being installed if that is the case because this is being tested against other implementations and if 1 of these functions after changes becomes more performant than the scalar it will be uncommented out.

Active tests are being run this was just a quick kill all until its figured out

@marauder2k7 marauder2k7 reopened this Jul 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants