Skip to content

列車種別なしの経路分岐を削除 - #1614

Open
TinyKitten wants to merge 6 commits into
devfrom
feature/remove-no-train-type-fallback
Open

列車種別なしの経路分岐を削除#1614
TinyKitten wants to merge 6 commits into
devfrom
feature/remove-no-train-type-fallback

Conversation

@TinyKitten

Copy link
Copy Markdown
Member

概要

起動時の各停列車種別補完を前提に、列車種別が存在しない場合の経路分岐を削除しました。

  • 駅ごとの列車種別有無を数える追加SQLと、種別なし用の駅取得SQLを削除
  • 路線取得を列車種別グループ経由の単一クエリへ統一
  • GetTrainRoute の種別なし各停フォールバックを削除
  • 経路ツリーは LineGroupId を必須の不変条件として扱うよう変更
  • 旧フォールバックを前提にしたテストデータとテストを更新

検証

  • cargo test --lib --package stationapi(425 passed / 55 ignored)
  • cargo clippy --workspace --all-targets --all-features -- -D warnings
  • cargo run -p data_validator(VALID)
  • git diff --check
  • make test-integration はローカルPostgreSQLの test ユーザーで password authentication failed のため未完了

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 13 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a2213bcb-1fa7-470d-943f-97cc6ed8e6af

📥 Commits

Reviewing files that changed from the base of the PR and between 1a4acc6 and 9278175.

📒 Files selected for processing (2)
  • stationapi/src/infrastructure/station_repository.rs
  • stationapi/src/use_case/interactor/query.rs

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the feature 要望対応や課題解決 label Aug 3, 2026
@TinyKitten TinyKitten self-assigned this Aug 3, 2026
@TinyKitten

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TinyKitten

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TinyKitten

Copy link
Copy Markdown
Member Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-dev feature 要望対応や課題解決

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant