特急ひだに東海道本線側の岐阜駅を追加 - #1619
Merged
Merged
Conversation
Contributor
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
🚉 停車駅の変更1 件の新しい停車パターン
🆕 ひだ(名古屋発着) (Hida(Nagoya to Toyama)) - 高山本線 / 東海道本線type_cd=225, line_group_cd=348 変更内容: 1 駅追加 全駅リスト (52駅)
|
TinyKitten
marked this pull request as ready for review
August 5, 2026 00:21
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
特急ひだ(名古屋発着)の停車パターンに、東海道本線側の岐阜駅を追加します。
変更の種類
変更内容
岐阜駅は高山本線側と東海道本線側で別の
station_cdを持ちますが、高山本線側(1141601)だけが登録され、東海道本線側(1150239)が欠けていました。type_cd=225,line_group_cd=348に東海道本線側の岐阜駅(1150239)を停車駅として追加します。これにより、アプリで東海道本線側の岐阜駅を選択した場合にも特急ひだを選択できます。テスト
cargo fmt --all -- --checkが通ることcargo clippy -- -D warningsが通ることcargo test(SQLX_OFFLINE=true)が通ること追加で以下を確認しました。
cargo run -p data_validator— 成功git diff --check— 成功関連Issue
なし
スクリーンショット(任意)
なし