Skip to content

Adding PublishToAudioAction to SIRI-SX#210

Open
TuThoThai wants to merge 13 commits into
v2.3-wipfrom
sx_cr_audiomessage
Open

Adding PublishToAudioAction to SIRI-SX#210
TuThoThai wants to merge 13 commits into
v2.3-wipfrom
sx_cr_audiomessage

Conversation

@TuThoThai

Copy link
Copy Markdown
Collaborator

Refers to the discussion on BaseCamp for adding pre-recorded audio messages when a situation occurs.

Change done only in siri_situationActions.xsd with:

  • the addition of PublishToAudioAction in ActionsGroup
  • definition of PublishToAudioActionStructure based on ParametrisedActionStructure with the extension of URL for the pre-recorded message

To be discussed in the SIRI-SX task force

@TuThoThai TuThoThai added this to the v2.3 milestone Apr 22, 2026
@TuThoThai TuThoThai added SX For everything SIRI-SX Needs CEN documentation Update These require CEN documentation update to match XSD & examples labels Apr 22, 2026
Comment thread xsd/siri_model/siri_situationActions.xsd
@TuThoThai TuThoThai requested a review from ue71603 April 22, 2026 09:19
ue71603
ue71603 previously approved these changes Apr 22, 2026
Comment thread xsd/siri_model/siri_situationActions.xsd Outdated
haeckerbaer
haeckerbaer previously approved these changes May 13, 2026

@haeckerbaer haeckerbaer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to add if skinkie's comment is taken care of

@TuThoThai TuThoThai dismissed stale reviews from haeckerbaer and ue71603 via 725b5c8 May 13, 2026 07:17
@TuThoThai

Copy link
Copy Markdown
Collaborator Author

I have applied @skinkie suggestion. For the type of the attribute, let's go with str for now and see if it needs to be updated once used.
Before merging this, I will add an example as asked.

@TuThoThai

Copy link
Copy Markdown
Collaborator Author

Example created, which led to the edit of the XSD to move the 2 attributes of the URL into the right order

Comment thread xsd/siri_model/siri_situationActions.xsd Outdated
@TuThoThai

Copy link
Copy Markdown
Collaborator Author

@skinkie, it ended up a tad more complicated than my original proposal to ensure both the XSD and the example validate. Kindly help with another review.

@TuThoThai TuThoThai requested a review from skinkie May 17, 2026 16:12
Comment thread examples/siri_exm_SX/exm_situationExchange_responsewithaudio.xml Outdated
Comment thread examples/siri_exm_SX/exm_situationExchange_responsewithaudio.xml Outdated
Comment thread examples/siri_exm_SX/exm_situationExchange_responsewithaudio.xml Outdated
Comment on lines +114 to +119
<ActionData>
<Type>RecordedMessage</Type>
</ActionData>
<Url type="audio/mpeg" xml:lang="fr">http://mediabank.aom.fr/audio/unattended_bag_fr.mp3</Url>
<Url type="audio/mpeg" xml:lang="en">http://mediabank.aom.fr/audio/unattended_bag_en.mp3</Url>
</PublishToAudioAction>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My proposal would still be to have the Url inside the ActionData. So it would look like analogue to the Prompts.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, then it means we add it to all the Actions in ActionsGroup that are based on ParametrisedActionStructure. I am not against it, but wouldn't it be redundant for PublishToWebAction or PublishToMobileAction?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it would support publishing other media like images too. Hence I thought that was your goal for the République française!

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skinkie, I addressed the comment in PR #221

If we can agree on that, I will rework this one to streamline PublishToAudioAction to attributes that are specific to an audio message.

- Change in `Prompt` to embed MIME content type
- Addition of `Url` with a specific type to embed MIME content type and language
- All served with an example
@TuThoThai

Copy link
Copy Markdown
Collaborator Author

During the SIRI-SX meeting of 19 may 2026, the assessment was that the PR is not yet ready for review. Discussed changes / paints points are to be addressed.
Moving back this PR to draft to work on it and make it ready for review on 12 June 2026

@TuThoThai TuThoThai marked this pull request as draft May 19, 2026 13:34
haeckerbaer
haeckerbaer previously approved these changes Jun 9, 2026
TuThoThai and others added 12 commits July 15, 2026 19:34
- Adding the element Url in ActionDataStructure
- Adding the attribute contentType for both Prompt and Url elements
- Defining the enumeration related to contentType
…ndurl.xml

delete faulty example from previous try
Adding the possibility to publish a situation via a pre-recorded message
- Same structure as the ParametrisedAction
- Only extension: URL for the pre-recorded message
possibility to give more details on the language in which the message has been recorded
Co-authored-by: Stefan de Konink <stefan@konink.de>
- Fixing the position of the URL attributes in the XSD
- Adding an example
- Add AudioURI in siri_types.xsd to allow for additional attributes (type for MIME and lang)
- Remove these attributes from siri_situationActions.xsd
- Edit example to match the changes in the XSD
Based on @skinkie review
Changed the attribute lang to xml:lang for consistency
Changed the example to reflect this
- In the example file, removal of the attribute `overridden`
- In the XSD, removal of a typo
- Add `PublishToAudioAction` based on extended `ActionData`
- Add an example with the use of `PublishToAudioAction`
@TuThoThai

Copy link
Copy Markdown
Collaborator Author

After the meeting of 19 May 2026, I did the following:

  • Rebase the branch so it takes into account changes from the branch sx_cr_actiondata_enhancement
  • Add PublishToAudioAction and its structure with 2 elements Repeat and RepeatInterval
  • Add an example using PublishToAudioAction

@TuThoThai TuThoThai marked this pull request as ready for review July 15, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs CEN documentation Update These require CEN documentation update to match XSD & examples SX For everything SIRI-SX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants