Change vehicle modes enum type in ET/PT filtered query#227
Merged
Conversation
This was referenced Jul 7, 2026
Collaborator
Author
|
@haeckerbaer if you have time to push an empty commit to this branch (it's done), I wonder if this will make CI pass (#228). |
haeckerbaer
previously approved these changes
Jul 14, 2026
haeckerbaer
left a comment
haeckerbaer
left a comment
Collaborator
There was a problem hiding this comment.
thanks a lot for catching that!!
#228 happens because the bot, for some reason, is not able to "write commit" to the repo. As a temporary work-around, I'm launching the same thing locally, which should ideally result in the bot having nothing to write, hence the PR would go green. This is theoretical at this point, let's see how it fares.
Collaborator
Author
|
While the commits history is a bit messy, I think it's OK reviewing this way, and it will serve as documentation in case future troubles arise. |
TuThoThai
approved these changes
Jul 16, 2026
skinkie
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues the move done in #207 (@haeckerbaer) to replace
VehicleModesEnumerationwithVehicleModesOfTransportEnumeration.While reviewing #207, I noticed that the old type still seems to be used on the querying side: the
VehicleModerequest filters of ET and PT. If I read correctly, a client can only filter on the old 9 values, while deliveries can now carry the full set ; a careful review is welcome.Since the new enumeration appears to be a superset of the old one, this should be backward compatible (except for tightly-coupled bindings users etc). If so, this also leaves
VehicleModesEnumerationunreferenced in the XSD; it stays deprecated (as per #207) and could be removed later.