リリースノートが 4 つ重複生成されるのを修正#54
Merged
Merged
Conversation
Each of the four binary matrix jobs invoked action-gh-release with generate_release_notes: true, so the generated notes were appended once per job (#52). A dedicated release job now creates the release with notes exactly once via the preinstalled gh CLI, and the matrix jobs only upload their asset. The view-before-create guard and --clobber keep re-runs after a partial failure working. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release workflow now creates a tagged GitHub release once in a dedicated job, then uploads platform binaries in a dependent job using the GitHub CLI with asset replacement enabled. ChangesRelease workflow
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #52
原因
binariesジョブの matrix (4 target) がそれぞれsoftprops/action-gh-releaseをgenerate_release_notes: true付きで呼んでいたため、既存リリースへのノート追記がジョブの数だけ発生していました (Issue のコメントの推測どおり、アセットの数 = matrix の数だけ重複)。変更内容
releaseジョブ (publish の後・binaries の前) で 1 回だけ行うようにしたgh release uploadによるアセットのアップロードのみに変更 (softprops/action-gh-releaseへの依存を削除。gh CLI は全 runner に同梱)--clobber付き留意点
🤖 Generated with Claude Code
Summary by CodeRabbit