remove the release workflow's issue-annotation job - #343
Merged
Conversation
GitHub already does the only part that matters. main is the default branch, so it closes any issue referenced by a closing keyword in the commits a release brings to main, and records the closing commit on the issue -- which is enough to find the release that fixed it. That left the job doing two things not worth an action: posting a comment naming the release, and removing the "closed in dev" label. Dropping both also removes a class of failure: the job had to reason about whether each matched number was an issue, a pull request, or nonexistent, and got it wrong in the v0.21.1 release, where it tried to comment on a pull request and failed. The label is now never removed, which is fine: `is:open label:"closed in dev"` still finds exactly the fixes that are merged but not yet released, because released ones are closed. Adding the label on pushes to dev is unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the last remaining issue-touching job from
release.yml, per theobservation that GitHub already does the part that matters.
mainis the default branch, so GitHub closes any issue referenced by a closingkeyword in the commits a release brings to
main, and records the closing commiton the issue — which is enough to trace back to the release.
That left the job doing two things not worth an action: posting a comment naming
the release, and removing the
closed in devlabel. Both are now gone.Dropping them also removes a whole class of failure. The job had to decide, for
every number its regex matched, whether it was an issue, a pull request, or
nonexistent — and it got that wrong in the v0.21.1 release, where it tried to
comment on a pull request (matched from an illustrative
"fixes #123"in acommit message) and failed with
Resource not accessible by integration.release.ymlis now two jobs: create the release, publish to PyPI.The label
It is never removed now, so it accumulates on closed issues. That is fine —
is:open label:"closed in dev"still finds exactly the fixes that are merged but not yet released, because
released ones are closed. CONTRIBUTING.md documents this.
Adding the label on pushes to
devis unchanged.