feat(datafabric): add OTEL span instrumentation and error classification#968
Open
UIPath-Harshit wants to merge 1 commit into
Open
feat(datafabric): add OTEL span instrumentation and error classification#968UIPath-Harshit wants to merge 1 commit into
UIPath-Harshit wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds OpenTelemetry span instrumentation around Data Fabric SQL execution and enriches failure handling by classifying EnrichedException instances into DataFabricError details that are propagated into the subgraph state and surfaced in termination messaging.
Changes:
- Instrument
QueryExecutorwith an OTEL span (attributes for SQL + entity metadata; success/error attributes). - Add
DataFabricError-based error classification and propagate last error category/detail throughDataFabricSubgraphStateand termination output. - Update dependency constraints/lockfile (
uipathupper bound,uipath-core+uipath-platformlock updates) and add a comprehensive new unit test suite for the subgraph.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/uipath_langchain/agent/tools/datafabric_tool/datafabric_subgraph.py |
Adds OTEL span wrapping, structured error classification, and state propagation for termination messaging. |
tests/agent/tools/test_datafabric_subgraph.py |
Introduces extensive unit tests for success/error paths, OTEL behavior, routing, and termination messaging. |
pyproject.toml |
Relaxes the uipath upper bound to allow <2.13.0. |
uv.lock |
Locks updated uipath-core and uipath-platform versions and reflects the new uipath bound. |
UIPath-Harshit
force-pushed
the
feat/datafabric-telemetry-spans
branch
from
876e253 to
af535e0
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 876e253ffb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ion for SQL queries - Add OpenTelemetry span around Data Fabric SQL query execution with entity metadata, success/error attributes, and structured error codes - Integrate DataFabricError classification from uipath-platform for richer error diagnostics (category, code, trace_id) on spans - Propagate error category and detail to parent graph state for termination messaging - Bump uipath upper bound to <2.13.0 and uipath-platform to 0.1.90 - Add comprehensive unit tests for datafabric_subgraph (98% coverage) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
UIPath-Harshit
force-pushed
the
feat/datafabric-telemetry-spans
branch
from
af535e0 to
d9d4896
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataFabricErrorclassification fromuipath-platformfor richer error diagnostics (category, code, trace_id) on spansuipathupper bound to<2.13.0and upgradeuipath-platformlockfile to0.1.90Test plan
test_datafabric_subgraph.pycovering:datafabric_subgraph.py🤖 Generated with Claude Code