workos: serve org roles on the authorization path the v10 SDK calls#13
Merged
Conversation
The Node SDK's authorization.listOrganizationRoles hits /authorization/organizations/:id/roles; the emulator only served the legacy /organizations/:id/roles, so the call 404'd and any org-roles load surfaced as a 500. Serve both paths from one handler, with a round-trip test through the real SDK. v0.13.5.
Pre-existing violations unrelated to the workos change; format:check runs the whole repo, so these blocked every PR's gate.
Pre-existing type-check break (RequestInfo isn't in the package's lib set); Request | string | URL is the same fetch input type without it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WorkOS Node SDK v10's
authorization.listOrganizationRolescallsGET /authorization/organizations/:id/roles, but the emulator only served the legacyGET /organizations/:id/roles. The call 404'd and any app loading an org's roles (a members-page role picker) surfaced it as a 500. Serve both paths from one handler, with a round-trip test through the real SDK. v0.13.5.