Fix Streamable HTTP MCP connection leaks#1423
Open
NickChristensen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The custom Effect HTTP-to-Fetch adapter only raced the initial response promise against the request's
AbortSignal.Once response headers had arrived, the adapter returned a
ReadableStreamthat was no longer connected to that signal. Callingclient.close()aborted the MCP transport, but the underlying long-lived GET/SSE response continued running and kept its TCP connection open.For request-scoped MCP clients, this could leave one established connection behind after each invocation and eventually exhaust available file descriptors.
Fix
The adapter now handles cancellation during both phases of a request:
Effect.runPromise.Stream.interruptWhenconnects the response stream to the same signal.This keeps the existing MCP transport lifecycle unchanged while ensuring local resources are released when the client closes.
Testing