Store file secrets under EXECUTOR_DATA_DIR when set#1431
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-cloud | 5eca314 | Jul 18 2026, 06:03 AM |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
executor-marketing | 5eca314 | Commit Preview URL Branch Preview URL |
Jul 18 2026, 06:01 AM |
Contributor
Cloudflare previewTorn down — the PR is closed. |
@executor-js/cli
@executor-js/config
@executor-js/execution
@executor-js/sdk
@executor-js/codemode-core
@executor-js/runtime-quickjs
@executor-js/plugin-file-secrets
@executor-js/plugin-graphql
@executor-js/plugin-keychain
@executor-js/plugin-mcp
@executor-js/plugin-onepassword
@executor-js/plugin-openapi
executor
commit: |
RhysSullivan
marked this pull request as ready for review
July 18, 2026 06:04
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fileSecretsPlugin()always wroteauth.jsonto the XDG data home, while the rest of the daemon's state lives underEXECUTOR_DATA_DIR. Deployments that persist only the data dir (containers, sandboxes) restored connection rows without their secret values, so token refresh failed with "Stored refresh token could not be resolved" while connections still listed as connected.auth.jsonnow defaults underEXECUTOR_DATA_DIRwhen it is set (an explicitdirectoryoption still wins, and the XDG location remains the fallback otherwise). Secrets in the legacy XDG file are migrated once on first use; malformed legacy files are skipped, while real I/O failures surface and leave the migration retryable. Concurrent first operations share a single migration attempt. Includes a regression test that recreates the environment with only the data dir preserved.