Skip to content

feat: remove Venus Flux ad banner - #5745

Merged
therealemjy merged 1 commit into
mainfrom
feat/remove-binance-wallet-banner
Jul 30, 2026
Merged

feat: remove Venus Flux ad banner#5745
therealemjy merged 1 commit into
mainfrom
feat/remove-binance-wallet-banner

Conversation

@therealemjy

Copy link
Copy Markdown
Member

Changes

  • remove Venus Flux ad banner

@therealemjy
therealemjy requested a review from cuzz-venus July 28, 2026 07:34
@changeset-bot

changeset-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: dedf878

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jul 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview Jul 28, 2026 8:47am
dapp-testnet Ready Ready Preview Jul 28, 2026 8:47am
venus.io Ready Ready Preview Jul 28, 2026 8:47am

Request Review

@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown

Greptile Summary

Removes the expired Venus Flux promotional banner from the EVM application.

  • Removes the banner from the dashboard carousel.
  • Deletes the banner component and image assets.
  • Removes its translations from all supported locales.
  • Adds a patch changeset for @venusprotocol/evm.

Confidence Score: 5/5

The PR appears safe to merge with the banner component, assets, carousel entry, and translation keys removed consistently.

The carousel supports a dynamic number of children, and no remaining imports, translation-key consumers, tests, or generated contracts reference the deleted banner.

Important Files Changed

Filename Overview
apps/evm/src/containers/AdBanner/index.tsx Cleanly removes the Venus Flux slide and import while retaining four dynamically supported carousel slides.
apps/evm/src/containers/AdBanner/VenusFluxBanner/index.tsx Deletes the banner component after removing its sole composition point and associated references.
apps/evm/src/libs/translations/translations/en.json Removes the unused Venus Flux translation namespace consistently with the other supported locales.
.changeset/upset-pets-wait.md Correctly records the user-visible banner removal as an EVM package patch.

Reviews (1): Last reviewed commit: "feat: remove Venus Flux ad banner" | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 83.29% 53103 / 63754
🔵 Statements 83.29% 53103 / 63754
🔵 Functions 63.53% 711 / 1119
🔵 Branches 72.84% 6114 / 8393
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/containers/AdBanner/index.tsx 100% 0% 100% 100%
Generated in workflow #13959 for commit dedf878 by the Vitest Coverage Report Action

@cuzz-venus cuzz-venus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@therealemjy
therealemjy merged commit 8aed6d7 into main Jul 30, 2026
5 checks passed
@therealemjy
therealemjy deleted the feat/remove-binance-wallet-banner branch July 30, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants